classification
Title: [PATCH] Fix broken grammar in "pydoc3 unittest"
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.7, Python 3.6, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, python-dev, shlomif
Priority: normal Keywords: patch

Created on 2016-09-28 14:08 by shlomif, last changed 2016-09-28 16:24 by shlomif. This issue is now closed.

Files
File name Uploaded Description Edit
python-fix-broken-grammar-in-pydoc3-unittest.patch shlomif, 2016-09-28 14:08 Patch. review
Messages (4)
msg277623 - (view) Author: Shlomi Fish (shlomif) * Date: 2016-09-28 14:08
Currently the comment in the example in "pydoc3 unittest" reads:

«
## test method names begin 'test*'
»

This is broken grammar and the attached patch against the hg default branch corrects it. All tests are passing and I disclaim any implicit or explicit ownership of my changes.
msg277629 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-09-28 14:27
New changeset 650775f10178 by Berker Peksag in branch '3.5':
Issue #28303: Fix grammar in unittest.__doc__, patch by Shlomi Fish
https://hg.python.org/cpython/rev/650775f10178

New changeset d0b509777443 by Berker Peksag in branch '3.6':
Issue #28303: Merge from 3.5
https://hg.python.org/cpython/rev/d0b509777443

New changeset 6b59551bb4fe by Berker Peksag in branch 'default':
Issue #28303: Merge from 3.6
https://hg.python.org/cpython/rev/6b59551bb4fe
msg277630 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-09-28 14:28
Good catch, thanks!
msg277643 - (view) Author: Shlomi Fish (shlomif) * Date: 2016-09-28 16:24
You're welcome, and thanks for applying the patch so quickly.
History
Date User Action Args
2016-09-28 16:24:21shlomifsetmessages: + msg277643
2016-09-28 14:28:38berker.peksagsetstatus: open -> closed

type: behavior
versions: + Python 3.5, Python 3.6
nosy: + berker.peksag

messages: + msg277630
resolution: fixed
stage: resolved
2016-09-28 14:27:56python-devsetnosy: + python-dev
messages: + msg277629
2016-09-28 14:08:16shlomifcreate