➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-09-16 11:25 by kaartic, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| antigravity-patch.patch | kaartic, 2016-09-16 11:24 | patch that changes URL in antigravity.py | review | |
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 552 | closed | dstufft, 2017-03-31 16:36 | |
| Messages (5) | |||
|---|---|---|---|
| msg276695 - (view) | Author: Kaartic Sivaraam (kaartic) * | Date: 2016-09-16 11:24 | |
I use a network that is monitored and filtered by Cyberoam. The use Cyberoam to block some websites, and some content. I came to know of the antigravity easter egg recently. I tried it using 'import antigravity' and it opened the xkcd website as expected, but did not display the picture. I was able to view the image, when I changed the URL from http://xkcd.com/353 to https://xkcd.com/353 I found that I could not view the image as Cyberoam (for some unknown reason) blocked the loading of the picture for the HTTP site. If it does not cause any compatibility issue or other issues, please change the URL in the antigravity library also to a HTTPS one. I request you to change this as this may go unnoticed to other people who are not aware of it. I have attached a patch that changes the URL. You may use it if it's ok changing the URL. |
|||
| msg276696 - (view) | Author: Christian Heimes (christian.heimes) *  |
Date: 2016-09-16 11:27 | |
xkcd redirects http to https. It makes sense to fix the module and use https. |
|||
| msg276704 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-09-16 11:50 | |
New changeset b8ac4ee42ad3 by Christian Heimes in branch '3.5': Issue #28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam. https://hg.python.org/cpython/rev/b8ac4ee42ad3 New changeset 0820d023077e by Christian Heimes in branch '3.6': Issue #28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam. https://hg.python.org/cpython/rev/0820d023077e New changeset 7ebd6271094d by Christian Heimes in branch 'default': Issue #28181: Get antigravity over HTTPS. Patch by Kaartic Sivaraam. https://hg.python.org/cpython/rev/7ebd6271094d New changeset 742a798c4da6 by Christian Heimes in branch 'default': Issue #28181: Add Kaartic Sivaraam to Misc/ACKS. https://hg.python.org/cpython/rev/742a798c4da6 |
|||
| msg276705 - (view) | Author: Christian Heimes (christian.heimes) * |
Date: 2016-09-16 11:54 | |
Thanks for your contribution! |
|||
| msg276712 - (view) | Author: Kaartic Sivaraam (kaartic) * | Date: 2016-09-16 13:31 | |
Don't Mention. It was my long time wish to contribute to open source projects. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:36 | admin | set | github: 72368 |
| 2017-03-31 16:36:32 | dstufft | set | pull_requests: + pull_request1049 |
| 2016-09-16 13:31:13 | kaartic | set | messages: + msg276712 |
| 2016-09-16 11:54:52 | christian.heimes | set | status: open -> closed resolution: fixed messages: + msg276705 stage: patch review -> resolved |
| 2016-09-16 11:50:49 | python-dev | set | nosy:
+ python-dev messages: + msg276704 |
| 2016-09-16 11:27:31 | christian.heimes | set | versions:
+ Python 3.5, Python 3.6 nosy: + christian.heimes messages: + msg276696 stage: patch review |
| 2016-09-16 11:25:00 | kaartic | create | |