This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Remove Py_CreateSymbolicLinkW
Type: enhancement Stage: patch review
Components: Library (Lib), Windows Versions: Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, eryksun, paul.moore, steve.dower, tim.golden, zach.ware
Priority: normal Keywords: patch

Created on 2016-09-13 06:19 by eryksun, last changed 2022-04-11 14:58 by admin.

Files
File name Uploaded Description Edit
issue_28113_01.patch eryksun, 2016-09-13 06:25 review
Pull Requests
URL Status Linked Edit
PR 12907 open berker.peksag, 2019-04-22 14:47
Messages (6)
msg276183 - (view) Author: Eryk Sun (eryksun) * (Python triager) Date: 2016-09-13 06:19
In 3.6, the Windows implementation of os.symlink can be simplified to directly call CreateSymbolicLinkW, since this function was added in Windows Vista. The support code for Py_CreateSymbolicLinkW can be removed from Modules/posixmodule.c. enable_symlink can also be removed because SeCreateSymbolicLinkPrivilege gets enabled automatically.
msg276184 - (view) Author: Eryk Sun (eryksun) * (Python triager) Date: 2016-09-13 06:25
This patch also updates Win32SymlinkTests and Win32JunctionTests to use the user's %TEMP% directory instead of the source tree. It's much more likely that %TEMP% is on the system volume, which should be an NTFS volume that supports symbolic links and junctions.
msg313446 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2018-03-08 16:20
We should look at merging this, though we need a few things to be done first (anyone can jump in and do these, doesn't have to be Eryk):

* patch needs to be converted to a GitHub PR
* we should use unique names within %TEMP% to avoid conflicts between tests running in parallel
* PEP 7 has changed since the original patch
* NEWS and maybe a What's New entry?
msg323658 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2018-08-17 14:19
Eryk, would you like to address Steve's comments and convert your patch to a GitHub pull request? Let me know if you don't have time to prepare a new patch.
msg323659 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2018-08-17 15:13
One other thing, I have come across some CI configurations recently where TEMP is not the best choice (e.g. when it's a mount point in a VM/container). It seems likely that at some point we'll centralize the "working directory" for the test suite in a way that can be overridden easily, so using one of the test.support members instead of %TEMP% directly will make that easier.
msg340656 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2019-04-22 14:48
Py_CreateSymbolicLinkW() has been removed in bpo-31512. PR 12907 updates tests to use support.TESTN.
History
Date User Action Args
2022-04-11 14:58:36adminsetgithub: 72300
2019-04-22 14:48:53berker.peksagsetmessages: + msg340656
2019-04-22 14:47:24berker.peksagsetpull_requests: + pull_request12834
2018-08-17 15:13:23steve.dowersetmessages: + msg323659
2018-08-17 14:19:24berker.peksagsetnosy: + berker.peksag

messages: + msg323658
versions: - Python 3.6, Python 3.7
2018-03-08 16:20:52steve.dowersetmessages: + msg313446
versions: + Python 3.8
2016-09-13 06:25:40eryksunsetfiles: + issue_28113_01.patch
keywords: + patch
messages: + msg276184

stage: needs patch -> patch review
2016-09-13 06:19:08eryksuncreate