This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: socket: finish constant to Enum/Flag conversion
Type: enhancement Stage: commit review
Components: Versions: Python 3.6
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: ethan.furman Nosy List: christian.heimes, ethan.furman, ned.deily, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2016-09-11 20:34 by ethan.furman, last changed 2022-04-11 14:58 by admin.

Files
File name Uploaded Description Edit
issue-socket.stoneleaf.01.patch ethan.furman, 2016-09-11 20:34
Messages (8)
msg275851 - (view) Author: Ethan Furman (ethan.furman) * (Python committer) Date: 2016-09-11 20:34
Split from issue23591.

Add IntFlag constants for consistency with IntEnum constants.
msg275852 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-09-11 20:35
New changeset 4a027e55dae3 by Ethan Furman in branch 'default':
issue28083: add IntFlag constants
https://hg.python.org/cpython/rev/4a027e55dae3
msg275854 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2016-09-11 20:59
socketmodule.c has more namespaces. Are you planning to wrap them, too?

NETLINK_
BTPROTO_
SOL_
HCI_
PF_
PACKET_
TIPC_
SCM_
ALG_ (*)
CAN_ (*)
RDS_ (*)
IPPROTO_
IP_
IPV6_
TCP_
EAI_
SHUT_
RCVALL_


(*) constant namespace has sub-namespaces, e,g ALG_SET_ and ALG_OP_
msg275867 - (view) Author: Ethan Furman (ethan.furman) * (Python committer) Date: 2016-09-11 22:05
I don't have enough socket experience to know which constants should go into what groups and what those groups should be called.  So far my involvement has been to switch other's patches to use Enum._convert instead of "globals().update(Enum.__members__)".  (This last patch was from Serhiy.)

I am not opposed, though.  ;)

If Larry is okay with adding those during beta 1 I can work on it, but there's no way I could get it done before tomorrow.
msg275868 - (view) Author: Ethan Furman (ethan.furman) * (Python committer) Date: 2016-09-11 22:06
Still need to update docs.
msg275870 - (view) Author: Christian Heimes (christian.heimes) * (Python committer) Date: 2016-09-11 22:09
You have to as Ned, not Larry. :)
msg275902 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2016-09-12 00:45
One could argue that it is a bug that the other constants are missing.  Ethan, if you can work with Christian to get them in by b2, that would be acceptable.
msg275931 - (view) Author: Ethan Furman (ethan.furman) * (Python committer) Date: 2016-09-12 03:08
Thanks, Ned!
History
Date User Action Args
2022-04-11 14:58:36adminsetgithub: 72270
2016-09-12 03:08:43ethan.furmansetassignee: ethan.furman
messages: + msg275931
2016-09-12 00:45:39ned.deilysetnosy: - larry
messages: + msg275902
2016-09-11 22:09:17christian.heimessetnosy: + ned.deily
messages: + msg275870
2016-09-11 22:06:05ethan.furmansetmessages: + msg275868
2016-09-11 22:05:05ethan.furmansetnosy: + larry
messages: + msg275867
2016-09-11 20:59:10christian.heimessetnosy: + christian.heimes
messages: + msg275854
2016-09-11 20:35:45python-devsetnosy: + python-dev
messages: + msg275852
2016-09-11 20:34:18ethan.furmancreate