➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-07-30 10:43 by EdSchouten, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| patch-no-eshutdown | EdSchouten, 2016-07-30 10:43 | Patch for making use of ESHUTDOWN optional | ||
| Messages (5) | |||
|---|---|---|---|
| msg271678 - (view) | Author: Ed Schouten (EdSchouten) * | Date: 2016-07-30 10:43 | |
While porting Python over to CloudABI (https://mail.python.org/pipermail/python-dev/2016-July/145708.html), we noticed that the core Python code maps ESHUTDOWN over to BrokenPipeError. This is fine, except for the fact that ESHUTDOWN is used unconditionally. It's not part of POSIX. Attached is a patch to make its use optional. |
|||
| msg271681 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2016-07-30 10:57 | |
Looks good to me, thanks! |
|||
| msg271684 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-07-30 11:13 | |
New changeset 77d16a5dc779 by Berker Peksag in branch 'default': Issue #27652: Expose ESHUTDOWN conditionally https://hg.python.org/cpython/rev/77d16a5dc779 |
|||
| msg271685 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-07-30 11:21 | |
Thanks again, Ed! Could you please sign the PSF contributor agreement at https://www.python.org/psf/contrib/contrib-form/ ? Also, you don't need to strip out the header part of the patch file (Mercurial didn't recognize it as a valid patch file). You may want to check https://docs.python.org/devguide/patch.html |
|||
| msg271686 - (view) | Author: Ed Schouten (EdSchouten) * | Date: 2016-07-30 11:54 | |
I've filed the contributor form earlier today, but I suspect it still takes some time to get processed. The reason why the Mercurial headers were missing from the patch was because I generated this patch from the Python 3.6.0a3 source tarball. I'll make sure to switch over to the Mercurial sources from now on. Thanks for the quick response! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:34 | admin | set | github: 71839 |
| 2016-07-30 11:54:03 | EdSchouten | set | messages: + msg271686 |
| 2016-07-30 11:21:55 | berker.peksag | set | status: open -> closed resolution: fixed messages: + msg271685 stage: commit review -> resolved |
| 2016-07-30 11:13:39 | python-dev | set | nosy:
+ python-dev messages: + msg271684 |
| 2016-07-30 10:57:41 | berker.peksag | set | nosy:
+ berker.peksag title: [Patch] Make use of non-standard error number ESHUTDOWN optional -> Make use of non-standard error number ESHUTDOWN optional messages: + msg271681 type: enhancement stage: commit review |
| 2016-07-30 10:43:39 | EdSchouten | create | |