➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-06-02 11:18 by hashimo, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| patch27180 | Evelyn Mitchell, 2016-06-08 01:19 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg266883 - (view) | Author: Masato HASHIMOTO (hashimo) | Date: 2016-06-02 11:18 | |
The behavior of Path().rename() is same as os.rename() (replaces silently if dest file is already existent on Unix) but it's difficult to catch from current pathlib documentation (I found it from source of pathlib) from comparing with replace(). IMHO, it should be described on pathlilb documentation. |
|||
| msg267708 - (view) | Author: Evelyn Mitchell (Evelyn Mitchell) *  |
Date: 2016-06-07 17:45 | |
*** cpythonmod/Doc/library/pathlib.rst 2016-06-07 11:29:07.200774979 -0600
--- cpython/Doc/library/pathlib.rst 2016-06-07 11:29:59.372777817 -0600
***************
*** 887,896 ****
.. method:: Path.rename(target)
! Rename this file or directory to the given *target*. On Unix,
! if *target* exists and is a file, it will be replaced silently
! if the user has permission. *target* can be either a string or
! another path object::
>>> p = Path('foo')
>>> p.open('w').write('some text')
--- 887,894 ----
.. method:: Path.rename(target)
! Rename this file or directory to the given *target*. *target* can be
! either a string or another path object::
>>> p = Path('foo')
>>> p.open('w').write('some text')
|
|||
| msg267759 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2016-06-08 01:05 | |
Could you please send your patch in unified diff format? See https://docs.python.org/devguide/patch.html for details. |
|||
| msg270271 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2016-07-12 22:11 | |
patch27180. LGTM. |
|||
| msg270367 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-07-14 04:45 | |
New changeset 270fd4493195 by Berker Peksag in branch '3.5': Issue #27180: Clarify Path.rename() behavior on Unix systems https://hg.python.org/cpython/rev/270fd4493195 New changeset 89821243621b by Berker Peksag in branch 'default': Issue #27180: Merge from 3.5 https://hg.python.org/cpython/rev/89821243621b |
|||
| msg270368 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-07-14 04:45 | |
Thanks! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:31 | admin | set | github: 71367 |
| 2016-07-14 04:45:56 | berker.peksag | set | status: open -> closed resolution: fixed messages: + msg270368 stage: patch review -> resolved |
| 2016-07-14 04:45:03 | python-dev | set | nosy:
+ python-dev messages: + msg270367 |
| 2016-07-12 22:11:59 | vstinner | set | nosy:
+ vstinner messages: + msg270271 |
| 2016-06-08 01:19:30 | Evelyn Mitchell | set | files: + patch27180 |
| 2016-06-08 01:05:57 | berker.peksag | set | nosy:
+ berker.peksag messages: + msg267759 stage: needs patch -> patch review |
| 2016-06-07 17:45:50 | Evelyn Mitchell | set | nosy:
+ Evelyn Mitchell messages: + msg267708 |
| 2016-06-02 15:38:44 | berker.peksag | set | keywords:
+ easy stage: needs patch versions: - Python 3.4 |
| 2016-06-02 11:18:19 | hashimo | create | |