classification
Title: Document license under which audioop is used
Type: Stage: patch review
Components: Documentation, Library (Lib) Versions: Python 3.9, Python 3.8, Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: docs@python Nosy List: akuchling, benjamin.peterson, docs@python, furkanonder, georg.brandl, hac.man, terry.reedy, vanl, vstinner
Priority: normal Keywords: patch

Created on 2008-04-29 00:22 by brett.cannon, last changed 2020-05-07 00:56 by terry.reedy.

Pull Requests
URL Status Linked Edit
PR 19972 open furkanonder, 2020-05-07 00:12
Messages (9)
msg65948 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-04-29 00:22
The audioop module contains a comment that is somewhat troubling from an 
IP standpoint:

  /* Code shamelessly stolen from sox, 12.17.7, g711.c
   ** (c) Craig Reese, Joe Campbell and Jeff Poskanzer 1989 */

Because of this it would be best to remove the current module and re-
implement it from scratch (or remove it entirely).
msg65952 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-04-29 02:17
I would support removing this in Py3k. It seems like a specialty module
not worth having in the standard library. Also, is this even being
maintained?
msg66023 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2008-04-30 20:20
It is, as most "old" standard modules, not actively maintained, but
there is always the chance that somebody will fix bugs as they are
reported :)

Anyway, the algorithms in it won't change, and if you want its removal I
predict there will be many people crying out.
msg105618 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2010-05-13 00:56
I found severe bugs (which may lead to security vulnerabilities) in audioop: #7673. Nobody fixed these errors (but my issue contains a patch).
msg112507 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2010-08-02 18:18
Current status: no lawsuit yet.
msg170115 - (view) Author: Aaron (hac.man) Date: 2012-09-09 16:13
The license from http://sox.sourcearchive.com/documentation/12.17.7/g711_8c-source.html

/*
 * This source code is a product of Sun Microsystems, Inc. and is provided
 * for unrestricted use.  Users may copy or modify this source code without
 * charge.
 *
 * SUN SOURCE CODE IS PROVIDED AS IS WITH NO WARRANTIES OF ANY KIND INCLUDING
 * THE WARRANTIES OF DESIGN, MERCHANTIBILITY AND FITNESS FOR A PARTICULAR
 * PURPOSE, OR ARISING FROM A COURSE OF DEALING, USAGE OR TRADE PRACTICE.
 *
 * Sun source code is provided with no support and without any obligation on
 * the part of Sun Microsystems, Inc. to assist in its use, correction,
 * modification or enhancement.
 *
 * SUN MICROSYSTEMS, INC. SHALL HAVE NO LIABILITY WITH RESPECT TO THE
 * INFRINGEMENT OF COPYRIGHTS, TRADE SECRETS OR ANY PATENTS BY THIS SOFTWARE
 * OR ANY PART THEREOF.
 *
 * In no event will Sun Microsystems, Inc. be liable for any lost revenue
 * or profits or other special, indirect and consequential damages, even if
 * Sun has been advised of the possibility of such damages.
 *
 * Sun Microsystems, Inc.
 * 2550 Garcia Avenue
 * Mountain View, California  94043
 */

That seems compatible with Python's licensing, no?  It seems like adding this license text to the file and also to the documentation in http://docs.python.org/license.html#licenses-and-acknowledgements-for-incorporated-software would make this a non-issue.  Assessment of the module's contents and whether it should be rewritten or removed seems like a separate issue.

I could write up a patch if people think that this would solve the problem.
msg217675 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2014-05-01 01:30
Audioop was not removed in 3.x; the security bugs have been fixed; and no lawsuit. I agree with Aaron about modifying 2 files. I would also change 'shamelessly stolen' to 'taken'. IP is no longer something to joke about.
msg241760 - (view) Author: A.M. Kuchling (akuchling) * (Python committer) Date: 2015-04-22 00:16
Van: what do you think?  I can prepare a patch for Aaron's suggested changes.
msg368316 - (view) Author: Furkan Onder (furkanonder) * Date: 2020-05-06 23:56
PR has been sent.
History
Date User Action Args
2020-05-07 00:56:43terry.reedysetversions: + Python 3.7, Python 3.8, Python 3.9, - Python 2.7, Python 3.4, Python 3.5
2020-05-07 00:12:02furkanondersetkeywords: + patch
stage: needs patch -> patch review
pull_requests: + pull_request19289
2020-05-06 23:56:26furkanondersetnosy: + furkanonder
messages: + msg368316
2015-04-22 00:16:09akuchlingsetnosy: + vanl, akuchling
messages: + msg241760
2014-05-01 01:32:55terry.reedysettitle: Reimplement audioop because of copyright issues -> Document license under which audioop is used
nosy: + docs@python

priority: high -> normal
assignee: docs@python
components: + Documentation
2014-05-01 01:30:26terry.reedysetnosy: + terry.reedy

messages: + msg217675
versions: + Python 3.4, Python 3.5, - Python 3.2, Python 3.3
2013-03-26 18:06:37brett.cannonsetnosy: - brett.cannon
2012-09-09 16:13:49hac.mansetnosy: + hac.man
messages: + msg170115
2011-06-12 18:40:31terry.reedysetstage: needs patch
versions: + Python 3.3, - Python 2.6, Python 3.1
2010-08-02 18:18:38georg.brandlsetmessages: + msg112507
2010-05-13 00:56:05vstinnersetnosy: + vstinner
messages: + msg105618
2010-05-11 20:35:52terry.reedysetversions: + Python 3.1, Python 2.7, Python 3.2, - Python 3.0
2008-04-30 20:20:02georg.brandlsetnosy: + georg.brandl
messages: + msg66023
2008-04-29 02:17:04benjamin.petersonsetnosy: + benjamin.peterson
messages: + msg65952
versions: + Python 3.0
2008-04-29 00:22:49brett.cannoncreate