This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Remove carbon-specific code from binhex
Type: behavior Stage:
Components: Library (Lib) Versions: Python 2.6
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: brett.cannon, mark.dickinson, ronaldoussoren, terry.reedy
Priority: high Keywords:

Created on 2008-04-29 00:08 by brett.cannon, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (9)
msg65947 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-04-29 00:08
There is carbon-specific code in binhex. It really should go so that the 
module is completely platform-independent. This is especially pertinent 
for 3.0 as all Mac-specific modules are slated to go.
msg66150 - (view) Author: Ronald Oussoren (ronaldoussoren) * (Python committer) Date: 2008-05-03 08:36
Have you read that code? The Carbon-specific code in there is needed to 
make the module behave correctly in OSX: the Carbon specific code is used 
to get and set some Mac-specific file attributes.

It should be easy enough to move that code into a small C extensions 
though, that way binhex will no longer depent on the Carbon python 
package.
msg66166 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-05-03 19:46
On Sat, May 3, 2008 at 1:36 AM, Ronald Oussoren <report@bugs.python.org> wrote:
>
>  Ronald Oussoren <ronaldoussoren@mac.com> added the comment:
>
>  Have you read that code?

Not in detail, no.

> The Carbon-specific code in there is needed to
>  make the module behave correctly in OSX: the Carbon specific code is used
>  to get and set some Mac-specific file attributes.
>
>  It should be easy enough to move that code into a small C extensions
>  though, that way binhex will no longer depent on the Carbon python
>  package.

OK.
msg91193 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2009-08-02 18:46
This came up again recently in issue 6621.

What's the current status of the binhex module in py3k?  It looks as 
though the Carbon-specific code has been *partially* but not completely 
removed.  In particular, there are references to FSSpec remaining, but 
no FSSpec is imported anywhere.

The references to FSSpec are all inside "if os.name == 'mac': ... " 
blocks.  On my 10.5/Intel and 10.4/PPC systems os.name gives 'posix', so 
these blocks never get executed.

Is it safe to simply remove these blocks?
msg91195 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2009-08-02 19:15
From my understanding the mac platform is OS 9, so that code in those 'if' 
blocks can go.
msg91201 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2009-08-02 20:10
Thanks, Brett.  I've removed those blocks in r74289 (py3k) and r74290 
(release31-maint).
msg91202 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2009-08-02 20:13
It looks to me as though this issue can now be closed.  Ronald, any 
comments?
msg104542 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2010-04-29 17:36
I would close this, but I am not sure what the resolution should be.
msg104547 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2010-04-29 17:54
Closing as fixed.
History
Date User Action Args
2022-04-11 14:56:33adminsetgithub: 46967
2010-04-29 17:55:05mark.dickinsonsetstatus: open -> closed
2010-04-29 17:54:55mark.dickinsonsetresolution: fixed
messages: + msg104547
2010-04-29 17:36:00terry.reedysetstatus: pending -> open
nosy: + terry.reedy
messages: + msg104542

2009-08-02 20:13:08mark.dickinsonsetstatus: open -> pending

messages: + msg91202
2009-08-02 20:10:59mark.dickinsonsetmessages: + msg91201
2009-08-02 19:15:39brett.cannonsetmessages: + msg91195
2009-08-02 18:47:20mark.dickinsonlinkissue6621 superseder
2009-08-02 18:46:13mark.dickinsonsetnosy: + mark.dickinson
messages: + msg91193
2008-05-03 19:46:57brett.cannonsetmessages: + msg66166
2008-05-03 08:36:44ronaldoussorensetnosy: + ronaldoussoren
messages: + msg66150
2008-04-29 00:08:06brett.cannoncreate