classification
Title: Add an option to skip _decimal module
Type: enhancement Stage: resolved
Components: Build, Cross-Build, Extension Modules Versions: Python 3.6
process
Status: closed Resolution: fixed
Dependencies: Superseder: Workaround for non-standard stdlib.h on Android
View: 26846
Assigned To: skrah Nosy List: Alex.Willmer, skrah, yan12125
Priority: normal Keywords: patch

Created on 2016-04-09 18:40 by yan12125, last changed 2016-04-26 09:12 by skrah. This issue is now closed.

Files
File name Uploaded Description Edit
allow-disable-libmpdec.patch yan12125, 2016-04-09 18:40
Messages (5)
msg263105 - (view) Author: Chih-Hsuan Yen (yan12125) * Date: 2016-04-09 18:40
As said by Stefan Krah in http://bugs.python.org/issue23496#msg236886, Android ports can use pure python decimal module. Of course I can, but _decimal is always built and error messages are spamming. This change allow disabling _decimal from ./configure.

For the complete build process, have a look into scripts and patches from https://github.com/yan12125/python3-android.
msg263106 - (view) Author: Stefan Krah (skrah) * (Python committer) Date: 2016-04-09 19:17
I thought you solved the locale problem in #20305. So it still does not build?
msg263107 - (view) Author: Stefan Krah (skrah) * (Python committer) Date: 2016-04-09 19:35
In any case:  It is not uncommon that some C module does not build.

You can disable modules in setup.py:

  # This global variable is used to hold the list of modules to be disabled.
  disabled_module_list = []
msg263109 - (view) Author: Chih-Hsuan Yen (yan12125) * Date: 2016-04-09 20:11
Regarding #20305: Now building is fine, while some runtime errors exist. I don't see reasons running ncurses on Android, so kicking those errors are not in my plan.

For this change: Thanks for pointing that variable - not noticing it before. Seems I still need to patch setup.py for disabling some specific modules? I don't like patches. They're just temporary workarounds for me. I see issue20210 proposing a general solution for disabling modules. Maybe I'll working on that instead.
msg264239 - (view) Author: Stefan Krah (skrah) * (Python committer) Date: 2016-04-26 09:12
After #26846 _decimal builds on Android.
History
Date User Action Args
2016-04-26 09:12:10skrahsetsuperseder: Workaround for non-standard stdlib.h on Android
resolution: rejected -> fixed
messages: + msg264239
2016-04-09 20:11:06yan12125setmessages: + msg263109
2016-04-09 19:35:17skrahsetstatus: open -> closed
messages: + msg263107

assignee: skrah
resolution: rejected
stage: resolved
2016-04-09 19:17:31skrahsetnosy: + skrah
messages: + msg263106
2016-04-09 18:40:00yan12125create