classification
Title: pyclbr module needs to be more flexible on loader support
Type: behavior Stage: test needed
Components: Library (Lib) Versions: Python 3.6
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: BTaskaya, eric.snow, ncoghlan, terry.reedy
Priority: normal Keywords:

Created on 2016-03-17 18:20 by eric.snow, last changed 2020-11-05 00:38 by BTaskaya.

Messages (1)
msg261924 - (view) Author: Eric Snow (eric.snow) * (Python committer) Date: 2016-03-17 18:19
(see issue26569)

The pyclbr module is showing its age (born 1995).  It assumes there are only 2 module types (builtin and source-based), particularly in readmodule() and readmodule_ex().  Really it should be source-based and "everything else".

For instance, it does not handle namespace packages correctly, since the spec.loader is set to None there.  It also doesn't handle frozen modules (e.g. "./python Lib/pyclbr.py _frozen_importlib").  This is likewise a problem for other/custom loaders that don't match the expectations of pyclbr.

Here are some things that should be done:

* replace custom introspection code with newer tools like importlib.util.module_from_spec()
* special-case namespace modules (since their spec.loader is None); this is probably a moot point if module_from_spec() gets used
* ignore more than just builtins; explicitly check for importlib.abc.SourceLoader?
* make use of similar tools in the inspect module?
History
Date User Action Args
2020-11-05 00:38:28BTaskayasetnosy: + terry.reedy, BTaskaya
2020-11-04 21:39:52brett.cannonsetnosy: - brett.cannon
2016-03-17 18:20:00eric.snowcreate