This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Backport some tests to 2.7
Type: enhancement Stage: resolved
Components: Tests Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: alexandre.vassalotti, martin.panter, pitrou, python-dev, rhettinger, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2016-03-05 08:41 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
pickletests_backport.patch serhiy.storchaka, 2016-03-05 08:41 review
Messages (6)
msg261209 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-03-05 08:41
Proposed patch backports some tests that makes sense for 2.7 from 3.x. This adds more assurance that we will not break anything in 2.7 bug fix and didn't break the compatibility unintentionally.
msg261210 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2016-03-05 08:53
+1 These tests may well provide early detection of backport errors.
msg261234 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-03-06 07:06
New changeset ea5d01c7997e by Serhiy Storchaka in branch '2.7':
Issue #26486: Backported some pickle tests from 3.x.
https://hg.python.org/cpython/rev/ea5d01c7997e
msg261330 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2016-03-08 07:19
I suspect this change is causing some buildbot failures (and failures on my computer). E.g. <http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%202.7/builds/1274>.

======================================================================
FAIL: test_int_pickling_efficiency (test.test_cpickle.cPickleTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/media/disk/home/proj/python/cpython/Lib/test/pickletester.py", line 1509, in test_int_pickling_efficiency
    self.assertEqual(sorted(sizes), sizes)
AssertionError: Lists differ: [5, 5, 6, 6, 8, 8, 8, 14, 14, ... != [5, 5, 6, 6, 8, 8, 8, 16, 18, ...

First differing element 7:
14
16

- [5, 5, 6, 6, 8, 8, 8, 14, 14, 16, 18, 19, 21, 22, 24]
+ [5, 5, 6, 6, 8, 8, 8, 16, 18, 19, 21, 22, 24, 14, 14]
msg261336 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2016-03-08 09:05
New changeset ff2368d5c1d3 by Serhiy Storchaka in branch '2.7':
Issue #26486: Removed pickle test that doesn't work in 2.7 on 64-bit platform.
https://hg.python.org/cpython/rev/ff2368d5c1d3
msg261337 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2016-03-08 09:08
Thanks Martin. This test just doesn't work in 2.7 on all platforms.
History
Date User Action Args
2022-04-11 14:58:28adminsetgithub: 70673
2016-03-08 09:08:10serhiy.storchakasetstatus: open -> closed

messages: + msg261337
2016-03-08 09:05:02python-devsetmessages: + msg261336
2016-03-08 07:19:59martin.pantersetstatus: closed -> open
nosy: + martin.panter
messages: + msg261330

2016-03-06 07:10:06serhiy.storchakasetstatus: open -> closed
assignee: serhiy.storchaka
resolution: fixed
stage: patch review -> resolved
2016-03-06 07:06:15python-devsetnosy: + python-dev
messages: + msg261234
2016-03-05 08:53:55rhettingersetnosy: + rhettinger
messages: + msg261210
2016-03-05 08:41:19serhiy.storchakacreate