Created on 2016-02-08 07:55 by martin.panter, last changed 2016-02-10 06:37 by martin.panter. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| allows-to.patch | martin.panter, 2016-02-08 07:55 | review | ||
| Messages (6) | |||
|---|---|---|---|
| msg259827 - (view) | Author: Martin Panter (martin.panter) *  |
Date: 2016-02-08 07:55 | |
This patch changes instances of “. . . allows to <verb>” to “. . . allows <verb>ing” or similar. I understand the original form is not correct English grammar, although the equivalent is apparently valid in some other languages. As a native English speaker it feels awkward to me, although the meaning is clear. This question & answer <https://english.stackexchange.com/questions/60271/grammatical-complements-for-allow> seem to back me up, but I thought I should get a quick review or second opinion before changing everything. |
|||
| msg259829 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-02-08 08:59 | |
I have read the patch, and it LGTM. At least it does exactly what is declared (and fixes some other minor errors). Thank you Martin. |
|||
| msg259857 - (view) | Author: Eric V. Smith (eric.smith) * |
Date: 2016-02-08 16:15 | |
I agree that the "to xxx" changes look good. And the handful of other corrections look good, too. I left a review comment with one typo I found. |
|||
| msg259980 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2016-02-10 05:47 | |
New changeset 818e91105418 by Martin Panter in branch '3.5': Issue #26304: Change "allows to <verb>" to "allows <verb>ing" or similar https://hg.python.org/cpython/rev/818e91105418 New changeset d01abc2d5197 by Martin Panter in branch 'default': Issue #26304: Merge doc wording from 3.5 https://hg.python.org/cpython/rev/d01abc2d5197 New changeset 37f6f965023d by Martin Panter in branch 'default': Issue #26304: Additional “allows to” fix specific to 3.6 https://hg.python.org/cpython/rev/37f6f965023d |
|||
| msg259982 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-02-10 06:31 | |
New changeset 4cfc19f667aa by Martin Panter in branch '2.7': Issue #26304: Change "allows to <verb>" to "allows <verb>ing" or similar https://hg.python.org/cpython/rev/4cfc19f667aa |
|||
| msg259983 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2016-02-10 06:37 | |
Thanks for the reviews, and spotting my typo. I also sneaked in eight more changes (“allowing to”), to asyncio-eventloop.rst, ctypes.rst, whatsnew/3.3.rst, howto/pyporting.rst, Misc/NEWS, and Misc/HISTORY. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2016-02-10 06:37:30 | martin.panter | set | status: open -> closed resolution: fixed messages: + msg259983 stage: patch review -> resolved |
| 2016-02-10 06:31:30 | python-dev | set | messages: + msg259982 |
| 2016-02-10 05:47:07 | python-dev | set | nosy:
+ python-dev messages: + msg259980 |
| 2016-02-08 16:15:15 | eric.smith | set | nosy:
+ eric.smith messages: + msg259857 |
| 2016-02-08 08:59:47 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg259829 |
| 2016-02-08 08:25:01 | serhiy.storchaka | set | nosy:
+ r.david.murray |
| 2016-02-08 07:55:32 | martin.panter | create | |