➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2016-01-01 07:45 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| use_version_info.patch | serhiy.storchaka, 2016-01-01 07:44 | review | ||
| use_version_info_2.patch | serhiy.storchaka, 2016-02-09 16:32 | review | ||
| use_version_info_3.patch | serhiy.storchaka, 2016-02-10 08:43 | review | ||
| Messages (10) | |||
|---|---|---|---|
| msg257279 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2016-01-01 07:44 | |
Proposed patch replaces all occurrences of sys.version[:3] with '%d.%d' % sys.version_info[:2]. The former doesn't work with non-one-digit versions (such as 3.10 and 10.1). |
|||
| msg259875 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-02-08 19:08 | |
Could anyone please make a review? We should solve this issue before releasing 3.10. |
|||
| msg259879 - (view) | Author: Andrew Plummer (aplummer) * | Date: 2016-02-08 20:03 | |
On a related note, I think that https://hg.python.org/cpython/file/tip/Makefile.pre.in#l571 should get the same treatment. |
|||
| msg259882 - (view) | Author: SilentGhost (SilentGhost) *  |
Date: 2016-02-08 20:18 | |
> On a related note, I think that https://hg.python.org/cpython/file/tip/Makefile.pre.in#l571 should get the same treatment. Agree, that should be included in the patch. |
|||
| msg259910 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2016-02-09 02:49 | |
See also Issue 24916 about more related fixes in Lib/sysconfig.py |
|||
| msg259943 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-02-09 16:32 | |
Update patch uses less cryptic formatting expressions (thanks SilentGhost for suggestion), fixes Makefile.pre.in (thanks Andrew), and fixes yet few files. |
|||
| msg259993 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2016-02-10 08:43 | |
Updated patch addresses SilentGhosts comments. |
|||
| msg259995 - (view) | Author: SilentGhost (SilentGhost) * |
Date: 2016-02-10 08:52 | |
No further comments from me. |
|||
| msg260043 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2016-02-10 22:07 | |
Review: LGTM, with a minor comment. |
|||
| msg260085 - (view) | Author: Roundup Robot (python-dev) |
Date: 2016-02-11 11:11 | |
New changeset 935d7804d1be by Serhiy Storchaka in branch 'default': Issue #25985: sys.version_info is now used instead of sys.version https://hg.python.org/cpython/rev/935d7804d1be |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:25 | admin | set | github: 70173 |
| 2016-02-11 11:34:09 | serhiy.storchaka | set | status: open -> closed assignee: serhiy.storchaka resolution: fixed stage: patch review -> resolved |
| 2016-02-11 11:11:03 | python-dev | set | nosy:
+ python-dev messages: + msg260085 |
| 2016-02-10 22:07:00 | vstinner | set | nosy:
+ vstinner messages: + msg260043 |
| 2016-02-10 08:52:07 | SilentGhost | set | messages: + msg259995 |
| 2016-02-10 08:43:12 | serhiy.storchaka | set | files:
+ use_version_info_3.patch messages: + msg259993 |
| 2016-02-09 16:32:53 | serhiy.storchaka | set | files:
+ use_version_info_2.patch messages: + msg259943 |
| 2016-02-09 02:49:40 | martin.panter | link | issue24916 dependencies |
| 2016-02-09 02:49:29 | martin.panter | set | nosy:
+ martin.panter messages: + msg259910 |
| 2016-02-08 20:18:10 | SilentGhost | set | nosy:
+ SilentGhost messages: + msg259882 |
| 2016-02-08 20:03:16 | aplummer | set | nosy:
+ aplummer messages: + msg259879 |
| 2016-02-08 19:08:06 | serhiy.storchaka | set | messages: + msg259875 |
| 2016-01-01 07:45:03 | serhiy.storchaka | create | |