Title: ErrorHandler buffer overflow in ?unused? SGI extension module almodule.c
Type: security Stage:
Components: Extension Modules Versions: Python 2.5
Status: closed Resolution: wont fix
Dependencies: Superseder:
Assigned To: Nosy List: gvanrossum, jnferguson
Priority: normal Keywords:

Created on 2008-04-08 16:13 by jnferguson, last changed 2009-03-29 03:14 by gvanrossum. This issue is now closed.

Messages (2)
msg65180 - (view) Author: Justin Ferguson (jnferguson) Date: 2008-04-08 16:13
I don't think any of these SGI modules even get used, but they're really
buggy-- you guys might want to consider just dropping them all together.

When printing errors larger than 128 bytes a stack based overflow occurs.

  44 static void
  45 ErrorHandler(long code, const char *fmt, ...)
  46 {
  47         va_list args;
  48         char buf[128];
  50         va_start(args, fmt);
  51         vsprintf(buf, fmt, args);
  52         va_end(args);
  53         PyErr_SetString(ErrorObject, buf);
  54 }
msg84364 - (view) Author: Guido van Rossum (gvanrossum) * (Python committer) Date: 2009-03-29 03:14
(Almost) nobody uses these any more, so let's close as won't fix.  The
SGI modules are removed from 3.0.  The few people who still have Irix
could probably care less about the buffer overflows, but they *might*
care about the modules (otherwise they wouldn't be on Irix :-).
Date User Action Args
2009-03-29 03:14:07gvanrossumsetstatus: open -> closed

nosy: + gvanrossum
messages: + msg84364

resolution: wont fix
2008-04-08 16:13:32jnfergusoncreate