This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Clean up run_gdb() calls
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.6, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: martin.panter, python-dev, r.david.murray, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2015-12-07 23:57 by martin.panter, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
gdb-cleanup.patch martin.panter, 2015-12-07 23:57 review
Messages (3)
msg256092 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-12-07 23:57
This small patch cleans up two oddities calling run_gdb() in /Lib/test/test_gdb.py that I noticed. They were both added in revision b71cda2f48c6. The first one is a whole GDB command being passed to GDB as extra arguments. Notice “gdb --batch -nx” is in the argument tuple twice:

test_NULL_ob_type (test.test_gdb.PrettyPrintTests)
Ensure that a PyObject* with NULL ob_type is handled gracefully ... ('gdb', '--batch', '-nx', '-iex', 'add-auto-load-safe-path /media/disk/home/proj/python/cpython/python-gdb.py', 'gdb', '--batch', '-nx', '--eval-command=set breakpoint pending yes', '--eval-command=break builtin_id', '--eval-command=set print address off', '--eval-command=run', '--eval-command=set print entry-values no', '--eval-command=set v->ob_type=0', '--eval-command=backtrace', '--args', '/media/disk/home/proj/python/cpython/python', '-S', '-c', 'id(42)')
ok

The other is just an assignment that was never used.
msg256103 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-12-08 07:57
LGTM.
msg256135 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-12-09 03:20
New changeset 6902b2024d25 by Martin Panter in branch '3.5':
Issue #25820: Remove unused assignment and redundant GDB CLI arguments
https://hg.python.org/cpython/rev/6902b2024d25

New changeset 2e5fdb8a8874 by Martin Panter in branch 'default':
Issue #25820: Merge test_gdb fixes from 3.5
https://hg.python.org/cpython/rev/2e5fdb8a8874
History
Date User Action Args
2022-04-11 14:58:24adminsetgithub: 70006
2015-12-09 04:53:38martin.pantersetstatus: open -> closed
resolution: fixed
stage: commit review -> resolved
2015-12-09 03:21:00python-devsetnosy: + python-dev
messages: + msg256135
2015-12-08 07:57:35serhiy.storchakasetnosy: + serhiy.storchaka

messages: + msg256103
stage: patch review -> commit review
2015-12-07 23:57:25martin.pantercreate