classification
Title: update pure python datetime.timedelta creation
Type: enhancement Stage: commit review
Components: Library (Lib) Versions: Python 3.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: belopolsky Nosy List: bdkearns, belopolsky, p-ganssle, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2015-11-25 07:52 by bdkearns, last changed 2018-07-05 15:46 by p-ganssle.

Files
File name Uploaded Description Edit
timedelta.patch bdkearns, 2015-11-25 08:04 review
timedelta2.patch bdkearns, 2015-11-25 17:48 review
timedelta3.patch bdkearns, 2015-11-25 18:51 review
Messages (10)
msg255322 - (view) Author: Brian Kearns (bdkearns) * Date: 2015-11-25 07:52
Brings timedelta creation up to par with the (simpler) C equivalent. Gives a nice speed boost on the pure-py version (not worth much on CPython but useful on other implementations like PyPy).

Included in a few other small bug fixes/cleanups, should be self-explanatory.
msg255326 - (view) Author: Brian Kearns (bdkearns) * Date: 2015-11-25 08:04
Correct patch uploaded
msg255327 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-11-25 08:40
Does the patch fixes any bugs? If no, it can be applied only to developed version. If yes, needed tests.
msg255367 - (view) Author: Brian Kearns (bdkearns) * Date: 2015-11-25 17:24
Bug fixes are to the test suite itself, and the name cleanup, minor. Best classified as enhancement, apply where applicable.
msg255372 - (view) Author: Brian Kearns (bdkearns) * Date: 2015-11-25 17:48
Updated patch per review
msg255379 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-11-25 18:33
Looks you are missed Victor's and my comments.
msg255380 - (view) Author: Brian Kearns (bdkearns) * Date: 2015-11-25 18:51
Updated again
msg270525 - (view) Author: Alexander Belopolsky (belopolsky) * (Python committer) Date: 2016-07-16 01:01
Brian, we had a similar discussion in issue 20858, but I am still unsure about the relationship between our datetime.py and that in PyPy.  Do you use CPython version in PyPy?  If not, have you applied this patch and if so, can you link to a PyPy issue or a commit?
msg270526 - (view) Author: Alexander Belopolsky (belopolsky) * (Python committer) Date: 2016-07-16 01:17
For future reference, here is a link to PyPy history of datetime.py:

https://bitbucket.org/pypy/pypy/history-node/919e00b3e558/lib_pypy/datetime.py?at=default
msg305090 - (view) Author: Alexander Belopolsky (belopolsky) * (Python committer) Date: 2017-10-26 20:51
Brian, is this still relevant?  If so, cab you submit a pull request?
History
Date User Action Args
2018-07-05 15:46:39p-gansslesetnosy: + p-ganssle
2017-10-26 20:51:56belopolskysetmessages: + msg305090
versions: + Python 3.7, - Python 3.6
2016-07-16 01:17:28belopolskysetmessages: + msg270526
2016-07-16 01:01:21belopolskysetmessages: + msg270525
2016-03-23 19:39:54belopolskysetassignee: belopolsky
stage: patch review -> commit review
2015-11-25 18:51:55bdkearnssetfiles: + timedelta3.patch

messages: + msg255380
2015-11-25 18:33:08serhiy.storchakasetmessages: + msg255379
2015-11-25 17:48:28bdkearnssetfiles: + timedelta2.patch

messages: + msg255372
2015-11-25 17:24:06bdkearnssetmessages: + msg255367
2015-11-25 08:40:38serhiy.storchakasettype: enhancement
components: + Library (Lib)
versions: - Python 3.4, Python 3.5
nosy: + serhiy.storchaka, belopolsky

messages: + msg255327
stage: patch review
2015-11-25 08:04:14bdkearnssetfiles: + timedelta.patch

messages: + msg255326
2015-11-25 08:00:16bdkearnssetfiles: - timedelta.patch
2015-11-25 07:59:27bdkearnssetfiles: + timedelta.patch
2015-11-25 07:59:09bdkearnssetfiles: - timedelta.patch
2015-11-25 07:52:26bdkearnscreate