classification
Title: Enable ctypes.test.test_values.Win_ValuesTestCase for non-Windows
Type: enhancement Stage: resolved
Components: ctypes, Tests Versions: Python 3.6, Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: martin.panter, python-dev, zach.ware
Priority: normal Keywords: patch

Created on 2015-11-13 21:28 by martin.panter, last changed 2015-11-26 11:29 by martin.panter. This issue is now closed.

Files
File name Uploaded Description Edit
python-values.patch martin.panter, 2015-11-13 21:28 review
Messages (5)
msg254623 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-11-13 21:28
In /Lib/ctypes/test/test_values.py, three out of the five test cases are only run on Windows. There is a comment saying “This test only works when python itself is a dll/shared library”, and the tests run fine on Linux. So I propose to remove the Windows-only restriction, and rename the class from Win_ValuesTestCase to PythonValuesTestCase.

The immediate benefit for me is that I can see on Linux when I need to update one of those tests before I break a Windows builtbot :)

This test used to be completely disabled (probably by accident), and was enabled for Windows only in revision 6f63fff5c120. There was a comment <https://bugs.python.org/issue19493#msg206649> by Zach wondering if it shouldn’t be Windows-specific.
msg255399 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-11-26 02:56
New changeset 6a8fbb97c8d8 by Martin Panter in branch 'default':
Issue #25622: Rename to PythonValuesTestCase and enable for non-Windows
https://hg.python.org/cpython/rev/6a8fbb97c8d8
msg255405 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-11-26 10:45
New changeset 0325eca1927e by Martin Panter in branch '3.4':
Issue #25622: Rename to PythonValuesTestCase and enable for non-Windows
https://hg.python.org/cpython/rev/0325eca1927e

New changeset 18a74ef65d3f by Martin Panter in branch '3.5':
Issue #25622: Merge ctypes test from 3.4 into 3.5
https://hg.python.org/cpython/rev/18a74ef65d3f

New changeset 38f749f0a1bd by Martin Panter in branch '3.5':
Issue #25622: Use repr(bytes) to avoid BytesWarning
https://hg.python.org/cpython/rev/38f749f0a1bd
msg255409 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-11-26 11:22
New changeset 7b12b04f4f18 by Martin Panter in branch '2.7':
Issue #25622: Rename to PythonValuesTestCase and enable for non-Windows
https://hg.python.org/cpython/rev/7b12b04f4f18
msg255412 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-11-26 11:29
The buildbots don’t seem to be having any troubles with test_ctypes, so I assume my change is good.
History
Date User Action Args
2015-11-26 11:29:53martin.pantersetstatus: open -> closed
resolution: fixed
messages: + msg255412

stage: patch review -> resolved
2015-11-26 11:22:21python-devsetmessages: + msg255409
2015-11-26 10:45:18python-devsetmessages: + msg255405
2015-11-26 02:56:39python-devsetnosy: + python-dev
messages: + msg255399
2015-11-13 21:28:54martin.pantercreate