classification
Title: Increase unit test coverage for abc.py
Type: enhancement Stage: patch review
Components: Tests Versions: Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: iritkatriel, karlcow, szymon
Priority: normal Keywords: easy, patch

Created on 2015-10-26 03:14 by szymon, last changed 2021-01-01 13:40 by iritkatriel.

Files
File name Uploaded Description Edit
mywork.patch szymon, 2015-10-26 03:14 Patch to increase test coverage of abc.py review
Pull Requests
URL Status Linked Edit
PR 24034 open karlcow, 2021-01-01 01:00
Messages (4)
msg253453 - (view) Author: Szymon Trapp (szymon) Date: 2015-10-26 03:14
Added a new function to unit tests for abc.py to increase the test coverage, specifically for the usage of __subclasshook__.

This will cover lines 209-214.

Note: this is my first submission to Python and I'm following the advice to start with the unit tests coverage.
msg381912 - (view) Author: Irit Katriel (iritkatriel) * (Python triager) Date: 2020-11-26 19:53
The patch needs to be converted to a github PR.
msg384144 - (view) Author: karl (karlcow) * Date: 2021-01-01 01:02
@iritkatriel Github PR done. 
https://github.com/python/cpython/pull/24034
msg384167 - (view) Author: Irit Katriel (iritkatriel) * (Python triager) Date: 2021-01-01 13:40
This PR probably doesn't improve test coverage because the feature is tested indirectly (and directly from test_typing). But I think this test should be added nevertheless for completeness and to demonstrate how the feature works. 

That said, this test shows that the documentation of issubclass is not quite accurate when it states that "a class is considered a subclass of itself" 
 (https://docs.python.org/3/library/functions.html#issubclass).  

That should probably be a separate bpo.
History
Date User Action Args
2021-01-01 13:40:26iritkatrielsetversions: - Python 3.8, Python 3.9
2021-01-01 13:40:19iritkatrielsetmessages: + msg384167
2021-01-01 01:02:14karlcowsetmessages: + msg384144
2021-01-01 01:00:20karlcowsetkeywords: + patch
nosy: + karlcow
pull_requests: + pull_request22875
2020-11-27 11:20:13iritkatrielsetkeywords: + easy, - patch, easy (C)
2020-11-26 19:53:23iritkatrielsetversions: + Python 3.8, Python 3.9, Python 3.10, - Python 3.6
nosy: + iritkatriel

messages: + msg381912

keywords: + easy (C)
2015-10-27 17:07:42brett.cannonsetstage: patch review
2015-10-26 03:14:01szymoncreate