classification
Title: Add method reopenFile() in WatchedFileHandler class
Type: enhancement Stage: resolved
Components: Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Marian Horban, python-dev, vinay.sajip
Priority: normal Keywords: patch

Created on 2015-08-18 09:36 by Marian Horban, last changed 2015-10-01 19:55 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
add_reopen_file.patch Marian Horban, 2015-08-18 09:36 review
Messages (2)
msg248765 - (view) Author: Marian Horban (Marian Horban) Date: 2015-08-18 09:36
Method WatchedFileHandler::emit() makes 2 things:
1. reopens log file,
2. emits record.
Sometimes user wants to reopen file immediately after some action without emitting.
Code that reopens file must be moved to separate method to avoid copy-pasting code in programs that use this functionality.
Patch is provided.
msg252048 - (view) Author: Roundup Robot (python-dev) Date: 2015-10-01 19:55
New changeset 6d61b057c375 by Vinay Sajip in branch 'default':
Closes #24884: refactored WatchedFileHandler file reopening into a separate method, based on a suggestion and patch by Marian Horban.
https://hg.python.org/cpython/rev/6d61b057c375
History
Date User Action Args
2015-10-01 19:55:03python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg252048

resolution: fixed
stage: resolved
2015-08-18 13:20:28berker.peksagsetnosy: + vinay.sajip
2015-08-18 09:36:54Marian Horbancreate