Title: imp.get_magic() should return bytes, not bytearray
Type: behavior Stage:
Components: Extension Modules Versions: Python 3.0
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: amaury.forgeotdarc, benjamin.peterson, brett.cannon
Priority: normal Keywords: patch

Created on 2008-03-24 06:59 by brett.cannon, last changed 2008-04-24 20:36 by amaury.forgeotdarc. This issue is now closed.

File name Uploaded Description Edit
get_magic_bytes.patch benjamin.peterson, 2008-03-24 21:35
Messages (4)
msg64395 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-03-24 06:59
The magic cookie as returned by imp.get_magic() should be of the bytes 
type, not bytearray as the magic cookie will not ever change during the 
execution of the interpreter.
msg64443 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-03-24 21:35
Attaching patch...
msg65745 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-04-24 20:31
This was fixed as r62484.
msg65746 - (view) Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) * (Python committer) Date: 2008-04-24 20:36
Oops, sorry for missing the tracker item.
The change was sleeping in my workspace for some time...
Thanks for closing it.
Date User Action Args
2008-04-24 20:36:14amaury.forgeotdarcsetnosy: + amaury.forgeotdarc
messages: + msg65746
2008-04-24 20:31:22benjamin.petersonsetstatus: open -> closed
resolution: fixed
messages: + msg65745
2008-03-24 21:35:18benjamin.petersonsetfiles: + get_magic_bytes.patch
keywords: + patch
messages: + msg64443
nosy: + benjamin.peterson
2008-03-24 06:59:36brett.cannoncreate