classification
Title: raiseExceptions typo fix in logging tests
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.6, Python 3.5, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: Unit03, martin.panter, python-dev, serhiy.storchaka, vinay.sajip
Priority: normal Keywords: patch

Created on 2015-07-21 18:37 by Unit03, last changed 2015-07-21 19:43 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
test_logging_typo.patch Unit03, 2015-07-21 18:37 review
test_logging_typo.v2.patch Unit03, 2015-07-21 19:30 review
Messages (6)
msg247047 - (view) Author: Jacek Kołodziej (Unit03) * Date: 2015-07-21 18:37
The typo in test_logging was discovered while working on #23883: in two tests the addCleanup call reverts the raiseEx*ec*ptions value (instead of raiseExceptions) in logging module and apparently that didn't manifest itself in any way.

Patch attached.
msg247048 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-07-21 18:45
I would use test.support.swapattr().
msg247052 - (view) Author: Jacek Kołodziej (Unit03) * Date: 2015-07-21 19:30
s/swapattr/swap_attr/g :) Done.
msg247053 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-07-21 19:34
LGTM.
msg247054 - (view) Author: Roundup Robot (python-dev) Date: 2015-07-21 19:42
New changeset 20e2b980bb87 by Serhiy Storchaka in branch '3.4':
Issue #24678: Fixed raiseExceptions typo in logging tests.
https://hg.python.org/cpython/rev/20e2b980bb87

New changeset 7a54e400155f by Serhiy Storchaka in branch '3.5':
Issue #24678: Fixed raiseExceptions typo in logging tests.
https://hg.python.org/cpython/rev/7a54e400155f

New changeset 83b45ea19d00 by Serhiy Storchaka in branch 'default':
Issue #24678: Fixed raiseExceptions typo in logging tests.
https://hg.python.org/cpython/rev/83b45ea19d00
msg247056 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-07-21 19:43
Thank you for your contribution Jacek.
History
Date User Action Args
2015-07-21 19:43:09serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg247056

stage: commit review -> resolved
2015-07-21 19:42:02python-devsetnosy: + python-dev
messages: + msg247054
2015-07-21 19:34:14serhiy.storchakasetassignee: serhiy.storchaka
type: behavior
messages: + msg247053
stage: commit review
2015-07-21 19:30:03Unit03setfiles: + test_logging_typo.v2.patch

messages: + msg247052
2015-07-21 18:45:30serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg247048
2015-07-21 18:37:18Unit03create