classification
Title: Mention PYTHONFAULTHANDLER in the man page
Type: enhancement Stage: patch review
Components: Documentation Versions: Python 3.7, Python 3.6
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: docs@python Nosy List: Mariatta, berker.peksag, docs@python, matrixise, vstinner, zitterbewegung
Priority: normal Keywords: easy, patch

Created on 2015-06-16 20:51 by Antony.Lee, last changed 2017-10-26 22:51 by berker.peksag.

Files
File name Uploaded Description Edit
addMissingEnvVarsAndAlphabetize.patch zitterbewegung, 2016-05-21 22:31 Changes to man page to make it consistent with section 1.2 and alphabetization. review
addMissingEnvironmentVariables.patch zitterbewegung, 2016-06-03 21:44 Patch for the man page adding missing environment variables. review
addMissingEnvironmentVariables-review-1.patch zitterbewegung, 2016-06-05 19:58 Made man page documentation for patch clearer and more concise.
rebased_addMissingEnvironmentalVariables.patch zitterbewegung, 2016-10-10 00:33 review
correctedRebasedAddMissingEnvironmentalVariables.patch zitterbewegung, 2016-10-10 16:00 review
corrected.patch zitterbewegung, 2016-11-20 03:57 review
issue24459_cleanup.diff berker.peksag, 2017-02-06 10:03 review
issue24459_cleanup_2.diff berker.peksag, 2017-02-06 11:08 review
Pull Requests
URL Status Linked Edit
PR 4142 open berker.peksag, 2017-10-26 22:49
Messages (21)
msg245422 - (view) Author: Antony Lee (Antony.Lee) * Date: 2015-06-16 20:51
The man page doesn't mention PYTHONFAULTHANDER in the list of environment variables (I haven't thoroughly checked that everyone else is there, either).  I would also suggest reordering the environment variables in alphabetical order.
msg245424 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2015-06-16 21:07
PYTHONASYNCIODEBUG and PYTHONTRACEMALLOC are also missing.

I didn't know that Python has a manual page :-) (Misc/python.man)

Note: I added these 3 environment variables ;-)
msg266032 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2016-05-21 22:31
Hi, I have alphabetized and added the missing Environment Variables according to Section 1.2 https://docs.python.org/3.6/using/cmdline.html#environment-variables . I also added the missing environment variables from that documentation section.

Should Section 1.2 also be alphabetized? I noticed it wasn't.

This is my first contribution to python (I also just filled out the contributor forms) any comments and criticism is appreciated.
msg267135 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2016-06-03 18:56
Ping.
msg267159 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-06-03 20:36
> Hi, I have alphabetized and [...]

Can you please de-alphabetize the list to make patch review a little bit easier? Thanks!
msg267167 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2016-06-03 21:44
Undid alphabetization and added additional missing environment variables including debug mode variables.
msg267170 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-06-03 22:03
Thanks for the patch, Joshua. I did a quick review and it looks good to me. I will review and test it more carefully later today.
msg267380 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-06-05 04:59
I left some review comments on Rietveld: http://bugs.python.org/review/24459/
msg267470 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2016-06-05 19:58
I have reviewed the comments on Rietveld and made the changes to the patch. Attached is the revised version.
msg269918 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2016-07-07 02:31
ping
msg278174 - (view) Author: Mariatta Wijaya (Mariatta) * (Python committer) Date: 2016-10-06 05:24
Hi Joshua,
Seems like your latest patch doesn't apply cleanly to the default branch.
Can you rebase and upload a new patch?

Thanks.
msg278395 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2016-10-10 00:33
Hi I performed the rebase on the default branch.
msg278425 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2016-10-10 16:00
Thanks for reviewing Mariatta I have made a new patch that has those typos corrected.
msg280724 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2016-11-14 00:58
ping
msg280751 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-11-14 11:28
Thanks for the updated patch, Joshua. I will review and commit it this week.
msg281238 - (view) Author: Antony Lee (Antony.Lee) * Date: 2016-11-20 01:10
PYTHONUSERBASE is also missing.
msg281245 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2016-11-20 03:57
Thanks for pointing out that wasn't in the latest patch this has been corrected.
msg287116 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2017-02-06 10:03
Thanks for the patch and sorry for my late response. I did some tweaks and am planning to commit the tweaked version of your patch this week.
msg293171 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2017-05-06 19:50
Ping
msg298685 - (view) Author: Joshua Jay Herman (zitterbewegung) * Date: 2017-07-19 19:14
Was this ever merged? I'm not sure whats happening.
msg298789 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2017-07-21 09:20
> Was this ever merged?

No.

> I'm not sure whats happening.

Hum, nothing is happening. In december, Berker wrote "Thanks for the updated patch, Joshua. I will review and commit it this week." and then it seems like he found issues, since he proposed a new patch. And then, nothing new happened. Nobody reviewed latest Berker's patch and Berker maybe forgot to push it.

Can someone pick a recent patch and convert it to a GitHub PR? Berker, the author of the most recent patch, maybe?
History
Date User Action Args
2017-10-26 22:51:07berker.peksagsetversions: - Python 3.5
2017-10-26 22:49:01berker.peksagsetpull_requests: + pull_request4106
2017-07-21 09:20:23vstinnersetmessages: + msg298789
2017-07-19 19:14:25zitterbewegungsetmessages: + msg298685
2017-05-06 19:50:03zitterbewegungsetmessages: + msg293171
2017-02-06 11:08:29berker.peksagsetfiles: + issue24459_cleanup_2.diff
2017-02-06 10:03:25berker.peksagsetfiles: + issue24459_cleanup.diff

messages: + msg287116
2016-11-20 03:57:19zitterbewegungsetfiles: + corrected.patch

messages: + msg281245
2016-11-20 01:10:36Antony.Leesetnosy: - Antony.Lee
2016-11-20 01:10:18Antony.Leesetnosy: + Antony.Lee
messages: + msg281238
2016-11-14 11:28:39berker.peksagsetmessages: + msg280751
versions: + Python 3.7
2016-11-14 01:57:56Antony.Leesetnosy: - Antony.Lee
2016-11-14 00:58:46zitterbewegungsetmessages: + msg280724
2016-10-10 16:00:48zitterbewegungsetfiles: + correctedRebasedAddMissingEnvironmentalVariables.patch

messages: + msg278425
2016-10-10 00:33:50zitterbewegungsetfiles: + rebased_addMissingEnvironmentalVariables.patch

messages: + msg278395
2016-10-06 05:24:06Mariattasetnosy: + Mariatta
messages: + msg278174
2016-08-08 06:08:36matrixisesetnosy: + matrixise
2016-07-07 02:31:31zitterbewegungsetmessages: + msg269918
2016-06-05 19:58:01zitterbewegungsetfiles: + addMissingEnvironmentVariables-review-1.patch

messages: + msg267470
2016-06-05 04:59:07berker.peksagsetmessages: + msg267380
2016-06-03 22:03:11berker.peksagsetmessages: + msg267170
2016-06-03 21:44:25zitterbewegungsetfiles: + addMissingEnvironmentVariables.patch

messages: + msg267167
2016-06-03 20:36:47berker.peksagsetnosy: + berker.peksag

messages: + msg267159
stage: needs patch -> patch review
2016-06-03 18:56:34zitterbewegungsetmessages: + msg267135
2016-05-21 22:31:48zitterbewegungsetfiles: + addMissingEnvVarsAndAlphabetize.patch

nosy: + zitterbewegung
messages: + msg266032

keywords: + patch
2016-03-21 14:07:15berker.peksagsetkeywords: + easy
stage: needs patch
type: enhancement
versions: + Python 3.6
2015-06-16 21:07:21vstinnersetnosy: + vstinner
messages: + msg245424
2015-06-16 20:51:35Antony.Leecreate