This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Plug refleak in set_coroutine_wrapper
Type: behavior Stage: resolved
Components: Interpreter Core Versions: Python 3.6, Python 3.5
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: yselivanov Nosy List: gvanrossum, ncoghlan, python-dev, vstinner, yselivanov
Priority: normal Keywords: patch

Created on 2015-06-03 14:11 by yselivanov, last changed 2022-04-11 14:58 by admin. This issue is now closed.

File name Uploaded Description Edit
set_coro.patch yselivanov, 2015-06-03 14:11 review
set_coro.patch yselivanov, 2015-06-03 20:33 review
Messages (3)
msg244749 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2015-06-03 14:11
Code to raise RuntimeError introduced in issue24342 has some refleaks.  Please review the attached patch.
msg244808 - (view) Author: Nick Coghlan (ncoghlan) * (Python committer) Date: 2015-06-04 08:07
Ah, I'd missed that the previous code wouldn't clean up properly in the failure case.

+1 for inlining the check and using the existing error label.
msg244823 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-06-04 14:20
New changeset 3f2bf0ff262c by Yury Selivanov in branch '3.5':
Issue 24374: Plug refleak in set_coroutine_wrapper

New changeset 68f40b6448b9 by Yury Selivanov in branch 'default':
Issue 24374: Plug refleak in set_coroutine_wrapper
Date User Action Args
2022-04-11 14:58:17adminsetgithub: 68562
2015-06-04 14:20:49yselivanovsetstatus: open -> closed
type: behavior
resolution: fixed
stage: patch review -> resolved
2015-06-04 14:20:04python-devsetnosy: + python-dev
messages: + msg244823
2015-06-04 08:07:31ncoghlansetmessages: + msg244808
2015-06-03 20:33:06yselivanovsetfiles: + set_coro.patch
2015-06-03 14:19:09yselivanovsetnosy: + gvanrossum, vstinner
2015-06-03 14:11:59yselivanovcreate