classification
Title: test_errno fails with unexpected error value EREMOTEIO
Type: behavior Stage:
Components: Tests Versions: Python 3.0
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: andybalaam, brett.cannon
Priority: normal Keywords: patch

Created on 2008-03-18 16:16 by andybalaam, last changed 2008-03-18 16:35 by andybalaam. This issue is now closed.

Files
File name Uploaded Description Edit
add_more_error_values_to_test_errno.patch andybalaam, 2008-03-18 16:16 Patch to add all the error values named in errnomodule.c to the "errors" variable in test_errno.py
Messages (4)
msg63934 - (view) Author: Andy Balaam (andybalaam) * Date: 2008-03-18 16:16
Running test_errno on my 32-bit Ubuntu Gutsy machine gives me this:

$ ./python Lib/test/test_errno.py
test_for_improper_attributes (__main__.ErrnoAttributeTests) ... FAIL
test_using_errorcode (__main__.ErrnoAttributeTests) ... ok
test_attributes_in_errorcode (__main__.ErrorcodeTests) ... ok

======================================================================
FAIL: test_for_improper_attributes (__main__.ErrnoAttributeTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "Lib/test/test_errno.py", line 46, in test_for_improper_attributes
    "%s is an unexpected error value" % attribute)
AssertionError: EREMOTEIO is an unexpected error value

----------------------------------------------------------------------
Ran 3 tests in 0.001s

FAILED (failures=1)
Traceback (most recent call last):
  File "Lib/test/test_errno.py", line 68, in <module>
    test_main()
  File "Lib/test/test_errno.py", line 64, in test_main
    test_support.run_unittest(ErrnoAttributeTests, ErrorcodeTests)
  File "/home/andy/cvs/python/Lib/test/test_support.py", line 573, in
run_unittest
    _run_suite(suite)
  File "/home/andy/cvs/python/Lib/test/test_support.py", line 556, in
_run_suite
    raise TestFailed(err)
test.test_support.TestFailed: Traceback (most recent call last):
  File "Lib/test/test_errno.py", line 46, in test_for_improper_attributes
    "%s is an unexpected error value" % attribute)
AssertionError: EREMOTEIO is an unexpected error value

I've attached a patch which changes test_errno.py so that its list of
expected errors exactly matches the possible errors listed in
Modules/errnomodule.c in the latest SVN trunk.

I don't know whether this is the right solution, but the patch is there
if it is :)

Apologies if I've misunderstood something, or formatted the patch wrong
etc.  This is my first Python patch.
msg63936 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2008-03-18 16:26
Thanks for the patch, Andy, but I went ahead and fixed test_errno to
only explicitly test errno values from Standard C. That way we are not
constantly chasing our tail to support every errno value on every
platform that Python runs on.
msg63937 - (view) Author: Andy Balaam (andybalaam) * Date: 2008-03-18 16:29
Adding Brett Cannon since it looks like his checkin created the test
which fails on my machine.  Apologies if this is very bad etiquette.  I
couldn't find any guidelines about this in the developers' docs, but
probably that's because I am incompetent.
msg63938 - (view) Author: Andy Balaam (andybalaam) * Date: 2008-03-18 16:35
Woah! fast response, and what looks like a much more sensible fix. 
Thanks Brett.
History
Date User Action Args
2008-03-18 16:35:59andybalaamsetmessages: + msg63938
2008-03-18 16:29:23andybalaamsetmessages: + msg63937
2008-03-18 16:26:27brett.cannonsetstatus: open -> closed
resolution: out of date
messages: + msg63936
nosy: + brett.cannon
2008-03-18 16:16:40andybalaamcreate