This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Removal of dead code in smtpd
Type: performance Stage: resolved
Components: Library (Lib) Versions:
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Hoolean, python-dev
Priority: normal Keywords: patch

Created on 2015-04-05 00:57 by Hoolean, last changed 2022-04-11 14:58 by admin. This issue is now closed.

File name Uploaded Description Edit
correction.patch Hoolean, 2015-04-05 00:57 review
Messages (2)
msg240098 - (view) Author: (Hoolean) Date: 2015-04-05 00:57
Code was present that checked conditions that had previous been checked and had returned the function prematurely if the condition was true. As the condition has not changed before the check is made again, the condition will always be false and the code inside the if-statement will never be evaluated.

The attached patch removes unnecessary code.
msg240215 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-04-07 16:00
New changeset 81ce9d412a4c by Benjamin Peterson in branch '3.4':
remove smtpd dead code (closes #23873)

New changeset ea21b99d002e by Benjamin Peterson in branch 'default':
merge 3.4 (#23873)
Date User Action Args
2022-04-11 14:58:15adminsetgithub: 68061
2015-04-07 16:00:46python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg240215

resolution: fixed
stage: resolved
2015-04-05 00:57:43Hooleancreate