This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_ssl: fails on recent libressl version with BAD_DH_P_LENGTH
Type: Stage: resolved
Components: Versions: Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ced, ned.deily, pitrou, python-dev
Priority: normal Keywords: patch

Created on 2015-04-01 20:53 by ced, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
dh1024.patch ced, 2015-04-01 20:53 review
Messages (4)
msg239846 - (view) Author: Cédric Krier (ced) * Date: 2015-04-01 20:53
Since [1], libressl fails if DH keys are too small (<1024).
Here is a patch to increase the dh keys to 1024 for the tests.

[1] http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/ssl/s3_clnt.c?rev=1.108&content-type=text/x-cvsweb-markup
msg239865 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2015-04-02 00:47
Thanks for the patch. It should probably also remove the old file, unless it's also used somewhere else?
msg239873 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-04-02 04:08
New changeset 1ad7c0253abe by Benjamin Peterson in branch '3.4':
replace 512 bit dh key with a 2014 bit one (closes #23844)
https://hg.python.org/cpython/rev/1ad7c0253abe

New changeset 4f2391e86643 by Benjamin Peterson in branch '2.7':
replace 512 bit dh key with a 2014 bit one (closes #23844)
https://hg.python.org/cpython/rev/4f2391e86643

New changeset c27585e43e50 by Benjamin Peterson in branch 'default':
merge 3.4 (#23844)
https://hg.python.org/cpython/rev/c27585e43e50
msg298423 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2017-07-16 07:58
New changeset b52c0075511f8330f57c81520ee0287241d3653f by Ned Deily in branch '3.3':
bpo-23844: Fix test_dh_params failure
https://github.com/python/cpython/commit/b52c0075511f8330f57c81520ee0287241d3653f
History
Date User Action Args
2022-04-11 14:58:15adminsetgithub: 68032
2017-07-16 07:58:14ned.deilysetnosy: + ned.deily
messages: + msg298423
2016-01-21 22:45:02martin.panterlinkissue24985 superseder
2015-04-02 04:08:32python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg239873

resolution: fixed
stage: patch review -> resolved
2015-04-02 00:47:57pitrousetversions: + Python 2.7, Python 3.4, Python 3.5
nosy: + pitrou

messages: + msg239865

stage: patch review
2015-04-01 20:53:33cedcreate