This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: test_py_compile fails under -O
Type: Stage: resolved
Components: Tests Versions: Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: brett.cannon Nosy List: brett.cannon, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2015-03-31 13:39 by brett.cannon, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue23822.patch serhiy.storchaka, 2015-03-31 15:10 review
Messages (4)
msg239707 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2015-03-31 13:39
======================================================================
FAIL: test_double_dot_no_clobber (__main__.PyCompileTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/bcannon/Repositories/cpython/default/Lib/test/test_py_compile.py", line 115, in test_double_dot_no_clobber
    'foo.bar.{}.pyc'.format(sys.implementation.cache_tag)))
AssertionError: '__pycache__/foo.bar.cpython-35.pyo' != '__pycache__/foo.bar.cpython-35.pyc'
- __pycache__/foo.bar.cpython-35.pyo
?                                  ^
+ __pycache__/foo.bar.cpython-35.pyc
?
msg239723 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-03-31 15:10
Here is a patch.
msg240733 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-04-13 20:28
New changeset f4dd8629ec98 by Brett Cannon in branch 'default':
Issue #23822: Fix test_py_compile to not fail under -O.
https://hg.python.org/cpython/rev/f4dd8629ec98
msg240735 - (view) Author: Brett Cannon (brett.cannon) * (Python committer) Date: 2015-04-13 20:29
Thanks for the patch, Serhiy, but my PEP 488 patch invalidated yours. I just skipped it under -O rather than weakening the test to also work under -O.
History
Date User Action Args
2022-04-11 14:58:14adminsetgithub: 68010
2015-04-13 20:29:22brett.cannonsetstatus: open -> closed
resolution: fixed
messages: + msg240735

stage: patch review -> resolved
2015-04-13 20:28:20python-devsetnosy: + python-dev
messages: + msg240733
2015-03-31 15:10:41serhiy.storchakasetfiles: + issue23822.patch

nosy: + serhiy.storchaka
messages: + msg239723

keywords: + patch
stage: needs patch -> patch review
2015-03-31 13:39:13brett.cannoncreate