classification
Title: test_smtpnet uses incorrect port for STARTTLS
Type: Stage: resolved
Components: Tests Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ashkop, berker.peksag, python-dev
Priority: normal Keywords: patch

Created on 2015-02-26 10:01 by ashkop, last changed 2015-03-02 05:43 by berker.peksag. This issue is now closed.

Files
File name Uploaded Description Edit
test_smtpnet_starttls_port.patch ashkop, 2015-02-26 10:01 change port number for STARTTLS test review
Messages (3)
msg236658 - (view) Author: Alex Shkop (ashkop) * Date: 2015-02-26 10:01
test_smtpnet uses port 25 for STARTTLS, whereas gmail exposes STARTTLS SMTP over port 587.
msg237018 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-03-02 05:40
New changeset 06d69688ea06 by Berker Peksag in branch '3.4':
Issue #23527: Update Gmail port number for STARTTLS to 587.
https://hg.python.org/cpython/rev/06d69688ea06

New changeset 9ff477cd79da by Berker Peksag in branch 'default':
Issue #23527: Update Gmail port number for STARTTLS to 587.
https://hg.python.org/cpython/rev/9ff477cd79da
msg237019 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-03-02 05:43
Good catch. The test is skipped as "Resource 'smtp.gmail.com' is not available" on my machine.

See https://support.google.com/mail/answer/13287 for reference.

Thanks for the patch.
History
Date User Action Args
2015-03-02 05:43:11berker.peksagsetstatus: open -> closed

versions: + Python 3.4
nosy: + berker.peksag

messages: + msg237019
resolution: fixed
stage: resolved
2015-03-02 05:40:57python-devsetnosy: + python-dev
messages: + msg237018
2015-02-26 10:01:36ashkopcreate