➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015-02-26 07:35 by ashkop, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| test_httplib_warnings.patch | ashkop, 2015-02-26 07:35 | the patch | review | |
| httplib.patch | vstinner, 2015-02-26 16:30 | review | ||
| Messages (9) | |||
|---|---|---|---|
| msg236652 - (view) | Author: Alex Shkop (ashkop) * | Date: 2015-02-26 07:35 | |
Three resource warnings are present in test_httplib. Patch closes HTTPSConnection in test_networked_noverification, test_networked_trusted_by_default_cert, test_networked_good_cert. |
|||
| msg236657 - (view) | Author: Martin Panter (martin.panter) *  |
Date: 2015-02-26 09:44 | |
+1 from me. These three fixes are practically the same as the ones I snuck into my patch for a Issue 23377. |
|||
| msg236679 - (view) | Author: Demian Brecht (demian.brecht) *  |
Date: 2015-02-26 15:40 | |
LGTM |
|||
| msg236684 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2015-02-26 16:30 | |
I was going to commit the fix, but currently the 3.4 is not merged into default. I will wait until 3.4 is merged into default to apply the fix. I attach my pending commit. (Python 3.4 is also afffected.) |
|||
| msg236786 - (view) | Author: Roundup Robot (python-dev) |
Date: 2015-02-27 16:47 | |
New changeset 056d71d7bb28 by Victor Stinner in branch '3.4': Issue #23526: Fix ResourceWarning in test_httplib. Patch written by Alex Shkop. https://hg.python.org/cpython/rev/056d71d7bb28 |
|||
| msg236787 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2015-02-27 16:48 | |
I applied your patch. Thanks Alex Shkop! (FYI I also added your name to Misc/ACKS.) |
|||
| msg236798 - (view) | Author: Alex Shkop (ashkop) * | Date: 2015-02-27 17:19 | |
Thanks, great to hear. I'm glad to help) |
|||
| msg237853 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2015-03-11 08:48 | |
I think this one can be closed. Let me know if I was mistaken :) |
|||
| msg237854 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2015-03-11 08:51 | |
> I think this one can be closed. Let me know if I was mistaken :) Correct, I forgot to close it, thanks. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:13 | admin | set | github: 67714 |
| 2015-03-11 10:32:58 | berker.peksag | set | stage: commit review -> resolved |
| 2015-03-11 08:51:05 | vstinner | set | messages: + msg237854 |
| 2015-03-11 08:48:49 | martin.panter | set | status: open -> closed resolution: fixed messages: + msg237853 |
| 2015-02-27 17:19:00 | ashkop | set | messages: + msg236798 |
| 2015-02-27 16:48:28 | vstinner | set | messages: + msg236787 |
| 2015-02-27 16:47:52 | python-dev | set | nosy:
+ python-dev messages: + msg236786 |
| 2015-02-26 16:30:55 | vstinner | set | files:
+ httplib.patch versions: + Python 3.4 nosy: + vstinner messages: + msg236684 |
| 2015-02-26 15:41:09 | demian.brecht | set | stage: patch review -> commit review |
| 2015-02-26 15:40:52 | demian.brecht | set | nosy:
+ demian.brecht messages: + msg236679 type: behavior stage: patch review |
| 2015-02-26 09:44:57 | martin.panter | set | nosy:
+ martin.panter messages: + msg236657 |
| 2015-02-26 07:35:36 | ashkop | create | |