classification
Title: Keep http.server.__all__ up to date
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 3.5, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: berker.peksag, demian.brecht, martin.panter, python-dev
Priority: normal Keywords: patch

Created on 2015-02-09 07:03 by martin.panter, last changed 2015-02-13 18:53 by berker.peksag. This issue is now closed.

Files
File name Uploaded Description Edit
http.server-all.patch martin.panter, 2015-02-09 07:03 review
Messages (5)
msg235594 - (view) Author: Martin Panter (martin.panter) * (Python committer) Date: 2015-02-09 07:03
Here is a patch that adds the Simple/CGIHTTPRequestHandler classes to __all__, and a test case that should help keep it up to date in the future.
msg235597 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-02-09 08:22
LGTM.
msg235907 - (view) Author: Demian Brecht (demian.brecht) * Date: 2015-02-13 17:48
> LGTM.

+1
msg235910 - (view) Author: Roundup Robot (python-dev) Date: 2015-02-13 18:48
New changeset d2dbec7d74d0 by Berker Peksag in branch '3.4':
Issue #23418: Add missing entries to http.server.__all__.
https://hg.python.org/cpython/rev/d2dbec7d74d0

New changeset 03e3e78014ea by Berker Peksag in branch 'default':
Issue #23418: Add missing entries to http.server.__all__.
https://hg.python.org/cpython/rev/03e3e78014ea
msg235911 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2015-02-13 18:53
Fixed. Thanks Martin (also thanks to Demian for the review).
History
Date User Action Args
2015-02-13 18:53:18berker.peksagsetstatus: open -> closed
resolution: fixed
messages: + msg235911

stage: commit review -> resolved
2015-02-13 18:48:32python-devsetnosy: + python-dev
messages: + msg235910
2015-02-13 17:48:48demian.brechtsetnosy: + demian.brecht
messages: + msg235907
2015-02-09 08:22:24berker.peksagsetversions: + Python 3.4, Python 3.5
nosy: + berker.peksag

messages: + msg235597

stage: commit review
2015-02-09 07:03:43martin.pantercreate