➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015-02-08 10:21 by martin.panter, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| http-attributes.patch | martin.panter, 2015-02-08 10:22 | review | ||
| http-attributes.v2.patch | martin.panter, 2015-02-15 04:00 | review | ||
| http-attributes.v3.patch | martin.panter, 2015-02-17 04:04 | review | ||
| Messages (7) | |||
|---|---|---|---|
| msg235554 - (view) | Author: Martin Panter (martin.panter) *  |
Date: 2015-02-08 10:21 | |
[Padding to avoid Error: 'utf8' codec can't decode bytes in position 189-190: invalid continuation byte] This is a patch to document two attributes of http.server.BaseHTTPRequestHandler: “close_connection” and “requestline”. Normally these are set by the handle_one_request() method, but when overriding that method, you need to know to set these attributes. |
|||
| msg235941 - (view) | Author: Demian Brecht (demian.brecht) *  |
Date: 2015-02-14 01:36 | |
Minor comment in Rietveld, otherwise LGTM. |
|||
| msg236018 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2015-02-15 04:00 | |
Posting another patch which hopefully explains the “requestline” attribute a bit better. Let me know if you have any ideas for better wording. |
|||
| msg236124 - (view) | Author: Martin Panter (martin.panter) * |
Date: 2015-02-17 04:04 | |
Posting patch v3. It is based on Demian’s suggested wording for the requestline attribute, but adjusted to match the other entries, and to mention the empty string. |
|||
| msg236126 - (view) | Author: Demian Brecht (demian.brecht) * |
Date: 2015-02-17 05:05 | |
LGTM |
|||
| msg236127 - (view) | Author: Demian Brecht (demian.brecht) * |
Date: 2015-02-17 05:06 | |
Added Library component as there are a few newly added tests as well though and cosmetic changes were made to server.py. |
|||
| msg236162 - (view) | Author: Roundup Robot (python-dev) |
Date: 2015-02-18 02:13 | |
New changeset f9ff2a5bbbe2 by Benjamin Peterson in branch '3.4': document the requestline and close_connection attributes, use real booleans, and add tests (closes #23410) https://hg.python.org/cpython/rev/f9ff2a5bbbe2 New changeset 6e3e252cf047 by Benjamin Peterson in branch 'default': merge 3.4 (#23410) https://hg.python.org/cpython/rev/6e3e252cf047 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:12 | admin | set | github: 67598 |
| 2015-02-18 02:13:37 | python-dev | set | status: open -> closed nosy: + python-dev messages: + msg236162 resolution: fixed stage: resolved |
| 2015-02-17 05:28:48 | berker.peksag | set | nosy:
+ berker.peksag |
| 2015-02-17 05:06:41 | demian.brecht | set | messages:
+ msg236127 components: + Library (Lib) |
| 2015-02-17 05:05:39 | demian.brecht | set | messages: + msg236126 |
| 2015-02-17 04:04:36 | martin.panter | set | files:
+ http-attributes.v3.patch messages: + msg236124 |
| 2015-02-15 04:00:28 | martin.panter | set | files:
+ http-attributes.v2.patch messages: + msg236018 |
| 2015-02-14 01:36:05 | demian.brecht | set | messages: + msg235941 |
| 2015-02-13 17:17:52 | demian.brecht | set | nosy:
+ demian.brecht |
| 2015-02-08 10:22:07 | martin.panter | set | files:
+ http-attributes.patch keywords: + patch |
| 2015-02-08 10:21:17 | martin.panter | create | |