➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015-01-22 21:46 by CliffM, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| calendar_1.patch | Vipul.Sharma, 2015-01-28 14:45 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg234513 - (view) | Author: CliffM (CliffM) | Date: 2015-01-22 21:46 | |
calendar.py ( lines 17,18 ) is not used : # Exception raised for bad input (with string parameter for details) error = ValueError This could either be deleted OR used as the superclass in the next two class declarations as the comment suggests. |
|||
| msg234895 - (view) | Author: Vipul Sharma (Vipul.Sharma) * | Date: 2015-01-28 14:45 | |
I am submitting a patch file, hope this works. Please review it and correct me if I am wrong anywhere as this is my first contribution. |
|||
| msg234915 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2015-01-28 21:27 | |
Looks like "error" was unused since https://hg.python.org/cpython/rev/acdc0b9a6c78#l2.48 (see also https://hg.python.org/cpython/rev/6ee380349c84/ for time.gmtime()). LGTM. |
|||
| msg234917 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2015-01-28 21:53 | |
I suppose that calendar.error is here for compatibility. It is an alias to ValueError, so that errors raised by the calendar module can be catched with the "except calendar.error:" statement. Making calendar.error different class will likely break user code. I am inclined to reject this patch. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:12 | admin | set | github: 67493 |
| 2015-02-28 17:04:44 | berker.peksag | set | stage: commit review -> resolved |
| 2015-02-28 09:22:10 | serhiy.storchaka | set | status: open -> closed resolution: not a bug |
| 2015-01-28 21:53:03 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg234917 |
| 2015-01-28 21:27:12 | berker.peksag | set | nosy:
+ berker.peksag messages: + msg234915 stage: commit review |
| 2015-01-28 14:45:16 | Vipul.Sharma | set | files:
+ calendar_1.patch nosy: + Vipul.Sharma messages: + msg234895 keywords: + patch |
| 2015-01-22 22:00:42 | SilentGhost | set | keywords:
+ easy versions: + Python 3.5, - Python 3.6 |
| 2015-01-22 21:46:50 | CliffM | create | |