This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: refactor subprocess: use new OSError exceptions, factorize stdin.write() code
Type: enhancement Stage: resolved
Components: Library (Lib) Versions: Python 3.4, Python 3.5
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: gregory.p.smith, martin.panter, python-dev, serhiy.storchaka, vstinner
Priority: normal Keywords: patch

Created on 2015-01-13 23:41 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.

File name Uploaded Description Edit
subprocess.patch vstinner, 2015-01-13 23:41 review
Messages (4)
msg233974 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2015-01-13 23:41
Attached patch refactors subprocess code:

- use new OSError exceptions
- factorize stdin.write() code
msg234032 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2015-01-14 16:10
I commited my change to Python 3.5. Thanks for the review Serhiy & vadmium.
msg234033 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-01-14 16:15
New changeset 0c5ae257966f by Victor Stinner in branch 'default':
Closes #23234: Refactor subprocess
msg234109 - (view) Author: Gregory P. Smith (gregory.p.smith) * (Python committer) Date: 2015-01-16 02:25
thanks for the cleanup refactoring!
Date User Action Args
2022-04-11 14:58:11adminsetgithub: 67423
2015-01-23 10:56:04serhiy.storchakalinkissue16648 dependencies
2015-01-16 02:25:09gregory.p.smithsetmessages: + msg234109
2015-01-14 16:15:19python-devsetnosy: + python-dev

messages: + msg234033
stage: patch review -> resolved
2015-01-14 16:10:10vstinnersetmessages: + msg234032
2015-01-14 16:09:35vstinnersetstatus: open -> closed
resolution: fixed
2015-01-14 03:35:59berker.peksagsetnosy: + gregory.p.smith

components: + Library (Lib), - Extension Modules
stage: patch review
2015-01-14 02:01:43martin.pantersetnosy: + martin.panter
2015-01-13 23:41:01vstinnercreate