This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Respect the environment variable SVNROOT in external-common.bat
Type: enhancement Stage: resolved
Components: Build Versions: Python 3.4, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: anselm.kruis, python-dev, steve.dower, zach.ware
Priority: normal Keywords: patch

Created on 2015-01-04 07:35 by anselm.kruis, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue23160-3.4.diff anselm.kruis, 2015-01-04 07:40 Patch for 3.4 review
issue23160-2.7.diff anselm.kruis, 2015-01-04 07:42 Patch for 2.7
Messages (7)
msg233395 - (view) Author: Anselm Kruis (anselm.kruis) * Date: 2015-01-04 07:35
Issue #21907 introduced the environment variable SVNROOT in 
PCbuild/get_externals.bat.

I propose to use the same variable in Tools/buildbot/external-common.bat too. This batch contains many verbatim copies of the SVN-URL.
With the provided patch, it would become much simpler to use a (local) mirror of svn.python.org.
msg233396 - (view) Author: Anselm Kruis (anselm.kruis) * Date: 2015-01-04 07:40
Patch for 3.4
msg233397 - (view) Author: Anselm Kruis (anselm.kruis) * Date: 2015-01-04 07:42
Patch for 2.7
msg233558 - (view) Author: Steve Dower (steve.dower) * (Python committer) Date: 2015-01-07 02:11
Don't have time to apply them right now, but the patches look fine. I guess it'll null-merge into default, since 3.5 is unaffected?
msg233877 - (view) Author: Anselm Kruis (anselm.kruis) * Date: 2015-01-12 09:42
Your guess is correct, it will be a null merge into default.
msg234090 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-01-15 17:18
New changeset 294501835890 by Steve Dower in branch '2.7':
Closes #23160: Respect the environment variable SVNROOT in external-common.bat (patch by anselm.kruis)
https://hg.python.org/cpython/rev/294501835890
msg234091 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-01-15 17:18
New changeset 45e2c95bb802 by Steve Dower in branch '3.4':
Closes #23160: Respect the environment variable SVNROOT in external-common.bat (patch by anselm.kruis)
https://hg.python.org/cpython/rev/45e2c95bb802
History
Date User Action Args
2022-04-11 14:58:11adminsetgithub: 67349
2015-01-15 17:18:52python-devsetmessages: + msg234091
2015-01-15 17:18:30python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg234090

resolution: fixed
stage: patch review -> resolved
2015-01-12 09:42:07anselm.kruissetmessages: + msg233877
2015-01-07 02:11:36steve.dowersetmessages: + msg233558
2015-01-05 19:35:12pitrousetstage: patch review
2015-01-05 19:35:05pitrousetnosy: + steve.dower
2015-01-04 07:42:32anselm.kruissetfiles: + issue23160-2.7.diff
nosy: + zach.ware
messages: + msg233397

2015-01-04 07:40:09anselm.kruissetfiles: + issue23160-3.4.diff
keywords: + patch
messages: + msg233396
2015-01-04 07:35:09anselm.kruiscreate