classification
Title: unittest creates non-picklable errors
Type: behavior Stage: resolved
Components: Versions: Python 3.5, Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: ethan.furman, ezio.melotti, michael.foord, pitrou, python-dev, r.david.murray, rbcollins, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2014-11-19 19:49 by pitrou, last changed 2015-03-18 23:02 by pitrou. This issue is now closed.

Files
File name Uploaded Description Edit
pickle_module_import_failure.patch pitrou, 2015-03-18 21:45
Messages (7)
msg231398 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2014-11-19 19:49
Just got this:

_pickle.PicklingError: Can't pickle <class 'unittest.loader.ModuleImportFailure'>: attribute lookup ModuleImportFailure on unittest.loader failed

unittest should use regular exception classes instead.
msg231399 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2014-11-19 20:27
They aren't "real" exceptions, though, if I understand correctly.
msg238474 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2015-03-18 21:45
Here is a patch.
msg238476 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2015-03-18 22:11
classname is not used in _make_failed_test().
msg238478 - (view) Author: Robert Collins (rbcollins) * (Python committer) Date: 2015-03-18 22:30
LGTM please commit.
msg238480 - (view) Author: Roundup Robot (python-dev) Date: 2015-03-18 23:01
New changeset f3977f34cf6c by Antoine Pitrou in branch '3.4':
Issue #22903: The fake test case created by unittest.loader when it fails importing a test module is now picklable.
https://hg.python.org/cpython/rev/f3977f34cf6c

New changeset a1b5ac563d8d by Antoine Pitrou in branch 'default':
Issue #22903: The fake test case created by unittest.loader when it fails importing a test module is now picklable.
https://hg.python.org/cpython/rev/a1b5ac563d8d
msg238481 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2015-03-18 23:02
Thanks!
History
Date User Action Args
2015-03-18 23:02:13pitrousetstatus: open -> closed
resolution: fixed
messages: + msg238481

stage: patch review -> resolved
2015-03-18 23:01:46python-devsetnosy: + python-dev
messages: + msg238480
2015-03-18 22:30:56rbcollinssetmessages: + msg238478
2015-03-18 22:11:18serhiy.storchakasetnosy: + serhiy.storchaka
messages: + msg238476
2015-03-18 21:45:52pitrousettype: behavior
stage: patch review
2015-03-18 21:45:44pitrousetfiles: + pickle_module_import_failure.patch
keywords: + patch
messages: + msg238474
2014-11-19 20:27:24r.david.murraysetnosy: + r.david.murray
messages: + msg231399
2014-11-19 19:51:26ethan.furmansetnosy: + ethan.furman
2014-11-19 19:49:12pitroucreate