This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Get rid of references to PyInt in Py3 sources
Type: Stage: resolved
Components: Documentation Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, mark.dickinson, python-dev, serhiy.storchaka
Priority: normal Keywords: easy, patch

Created on 2014-11-16 14:12 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue22883.patch krypten, 2014-12-10 11:26 review
issue228813_msg232419.patch krypten, 2014-12-11 16:55 added changes according to msg232419 review
Messages (3)
msg231246 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-16 14:12
There are several references to PyInt in outdated comments in .c and .h files:

$ find * -name '*.[ch]' -exec egrep -n --color -- 'PyInt\b' '{}' +
Include/longobject.h:34:/* It may be useful in the future. I've added it in the PyInt -> PyLong
Modules/fcntlmodule.c:157:       into either a large positive number (PyLong or PyInt on 64-bit
Modules/fcntlmodule.c:158:       platforms) or a negative number on others (32-bit PyInt)
Modules/_json.c:813:        PyInt, PyLong, or PyFloat.
Modules/itertoolsmodule.c:3869:    assert(cnt != PY_SSIZE_T_MAX && long_cnt == NULL && long_step==PyInt(1));
Python/ceval.c:4606:/* Extract a slice index from a PyInt or PyLong or an object with the
msg232419 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-12-10 12:02
I doubt that just removing PyInt is correct. At least in longobject.h current comment looks correct. And in fcntlmodule.c and itertoolsmodule.c proposed changes look questionable.

There are also mentions of PyInt_* in *.rst and *.py files.
msg236128 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2015-02-17 08:19
New changeset 2f0c1937d716 by Serhiy Storchaka in branch 'default':
Issue #22883: Got rid of outdated references to PyInt and PyString in comments.
https://hg.python.org/cpython/rev/2f0c1937d716

New changeset c8d08de14030 by Serhiy Storchaka in branch '3.4':
Issue #22883: Update PyInt to PyLong in C API example.
https://hg.python.org/cpython/rev/c8d08de14030

New changeset c0b2dacef35c by Serhiy Storchaka in branch 'default':
Issue #22883: Update PyInt to PyLong in C API example.
https://hg.python.org/cpython/rev/c0b2dacef35c
History
Date User Action Args
2022-04-11 14:58:10adminsetgithub: 67072
2015-02-17 08:32:30serhiy.storchakasetstatus: open -> closed
resolution: fixed
stage: needs patch -> resolved
2015-02-17 08:19:55python-devsetnosy: + python-dev
messages: + msg236128
2015-02-10 20:09:31serhiy.storchakasetassignee: docs@python

components: + Documentation, - Extension Modules, Interpreter Core
nosy: + docs@python
2014-12-11 16:56:37kryptensetfiles: + issue228813_msg232419.patch
2014-12-11 16:56:19kryptensetfiles: - issue228813_msg232419.patch
2014-12-11 16:55:25kryptensetfiles: + issue228813_msg232419.patch
2014-12-10 12:02:08serhiy.storchakasetmessages: + msg232419
2014-12-10 11:26:24kryptensetfiles: + issue22883.patch
keywords: + patch
2014-12-09 14:15:32serhiy.storchakasetkeywords: + easy
2014-11-16 14:12:26serhiy.storchakacreate