This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: Minor tweaks dis documentation
Type: enhancement Stage: resolved
Components: Documentation Versions: Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: docs@python Nosy List: docs@python, georg.brandl, ncoghlan, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2014-11-11 07:42 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
doc_dis.patch serhiy.storchaka, 2014-11-11 07:42 review
Messages (4)
msg231003 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-11 07:42
Proposed patch changes dis documentation:

* formats the *file* parameter with stars, not ``backticks``.
* adds missed links to opcodes.
* fixes POP_STACK to POP_TOP.

I hesitate about TOS and TOS1 words. Should they be highlighted in any manner?
msg231004 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2014-11-11 07:51
LGTM. While at it, could you add a period after these:

+      Added *file* parameter
msg231006 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-11-11 08:06
New changeset d676f2725699 by Serhiy Storchaka in branch '3.4':
Issue #22845: Improved formatting of dis documentation.
https://hg.python.org/cpython/rev/d676f2725699

New changeset ac0334665459 by Serhiy Storchaka in branch 'default':
Issue #22845: Improved formatting of dis documentation.
https://hg.python.org/cpython/rev/ac0334665459

New changeset 0a32764004ab by Serhiy Storchaka in branch '2.7':
Issue #22845: Improved formatting of dis documentation.
https://hg.python.org/cpython/rev/0a32764004ab
msg231007 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-11 08:16
Done. Thank you Georg for your review.
History
Date User Action Args
2022-04-11 14:58:10adminsetgithub: 67034
2014-11-11 08:16:19serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg231007

stage: patch review -> resolved
2014-11-11 08:06:06python-devsetnosy: + python-dev
messages: + msg231006
2014-11-11 07:51:23georg.brandlsetmessages: + msg231004
2014-11-11 07:42:47serhiy.storchakacreate