This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Test pickling with all protocols
Type: enhancement Stage: resolved
Components: Tests Versions: Python 3.5
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: pitrou, python-dev, rhettinger, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2014-10-31 22:04 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

File name Uploaded Description Edit
tests_pickling.patch serhiy.storchaka, 2014-10-31 22:04 review
tests_pickling_2.patch serhiy.storchaka, 2014-11-01 08:23 review
Messages (3)
msg230395 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-10-31 22:04
Some pickling tests use only default protocol. Other tests use only lower protocols (0, 1, and may be 2). Proposed match makes all pickling tests using all existing protocols from 0 to HIGHEST_PROTOCOL inclusive. Also fixed some minor bugs.
msg230435 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-01 08:23
Fixed two bugs found by Antoine. Thank you Antoine.

Berker suggest to use the subTest() context manager inside loops. I thought about this, but this will increase blocks indentations on yet 4 spaces, and some code already is too indented. On other hand this truly helps when tests fail.

Large part of the patch is related to the code maintained by Raymond (collections and itertools modules, builtin collections and iterators), so it would be good if Raymond will look on it.
msg232656 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-12-15 12:09
New changeset 9927781e457f by Serhiy Storchaka in branch '2.7':
Issue #22777: Test pickling with all protocols.

New changeset 04c9fffde184 by Serhiy Storchaka in branch '3.4':
Issue #22777: Test pickling with all protocols.

New changeset 77fc30182dc2 by Serhiy Storchaka in branch 'default':
Issue #22777: Test pickling with all protocols.
Date User Action Args
2022-04-11 14:58:09adminsetgithub: 66966
2014-12-16 18:10:14serhiy.storchakasetstatus: open -> closed
2014-12-15 12:13:49serhiy.storchakasetassignee: serhiy.storchaka
resolution: fixed
stage: patch review -> resolved
2014-12-15 12:09:36python-devsetnosy: + python-dev
messages: + msg232656
2014-11-01 08:23:42serhiy.storchakasetfiles: + tests_pickling_2.patch

messages: + msg230435
2014-10-31 22:04:53serhiy.storchakacreate