➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-10-22 07:50 by Василий.Макаров, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue22695.diff | berker.peksag, 2014-11-01 17:54 | review | ||
| issue22695_v2.diff | berker.peksag, 2014-11-02 12:10 | review | ||
| Messages (13) | |||
|---|---|---|---|
| msg229802 - (view) | Author: Василий Макаров (Василий.Макаров) | Date: 2014-10-22 07:50 | |
Python 3 open() documentation ( https://docs.python.org/3/library/functions.html#open ) is probably broken. Here is what one can see at the end of open() description: "... Deprecated since version 3.4, will be removed in version 4.0. The 'U' mode." Reader may assume the open() function is what will be removed, which is wrong AFAIK |
|||
| msg229803 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2014-10-22 07:57 | |
New changeset a2ecc284eaa7 by Victor Stinner in branch '3.4': Issue #22695: Fix syntax of open() doc https://hg.python.org/cpython/rev/a2ecc284eaa7 |
|||
| msg229804 - (view) | Author: STINNER Victor (vstinner) *  |
Date: 2014-10-22 07:58 | |
> Reader may assume the open() function is what will be removed, which is wrong AFAIK It looks like an issue with the reST syntax in the documentation. Wait until the doc is regenerated (in a few hours) and then check again the doc please, to confirm that the issue is fixed. |
|||
| msg229805 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2014-10-22 09:01 | |
There are other "deprecated-removed" instructions without following empty line in the docs. Should they be changed? However the "deprecated" instruction works without following empty line. It looks as there is a bug in the implementation of the "deprecated-removed" instruction. |
|||
| msg229806 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2014-10-22 09:03 | |
"However the "deprecated" instruction works without following empty line. It looks as there is a bug in the implementation of the "deprecated-removed" instruction." Agreed, we can maybe enhance that. At least emit a warning? |
|||
| msg229822 - (view) | Author: R. David Murray (r.david.murray) * |
Date: 2014-10-22 13:34 | |
Presumably we can fix it. The code is in Docs/tools/pyspecific.py. Probably just need to figure out how it is different from the regular Sphinx deprecated tag implementation. |
|||
| msg230081 - (view) | Author: Василий Макаров (Василий.Макаров) | Date: 2014-10-27 17:49 | |
I can confirm this issue is fixed for now. Closing ticket.. |
|||
| msg230454 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2014-11-01 17:54 | |
Attached patch should fix the deprecated-removed directive. I've tested it with the following examples:
.. deprecated-removed:: 3.4 4.0
The ``'U'`` mode.
.. deprecated-removed:: 3.4 4.0
The ``'U'`` mode.
.. deprecated-removed:: 3.4 4.0
|
|||
| msg230485 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2014-11-02 12:10 | |
Here is a new patch. Thanks for the review, Serhiy. |
|||
| msg230488 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2014-11-02 15:05 | |
On my superficial view the patch looks good. But I am not well known with Sphinx code. |
|||
| msg230588 - (view) | Author: Georg Brandl (georg.brandl) * |
Date: 2014-11-04 07:50 | |
LGTM. |
|||
| msg230875 - (view) | Author: Roundup Robot (python-dev) |
Date: 2014-11-08 20:40 | |
New changeset 9001298e3094 by Berker Peksag in branch '3.4': Issue #22695: Fix rendering of the deprecated-removed role in HTML. https://hg.python.org/cpython/rev/9001298e3094 New changeset ec81edc30221 by Berker Peksag in branch 'default': Issue #22695: Fix rendering of the deprecated-removed role in HTML. https://hg.python.org/cpython/rev/ec81edc30221 |
|||
| msg230876 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2014-11-08 20:42 | |
Fixed. Thanks for the reviews. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:09 | admin | set | github: 66884 |
| 2014-11-08 20:42:58 | berker.peksag | set | status: open -> closed resolution: fixed messages: + msg230876 stage: commit review -> resolved |
| 2014-11-08 20:40:51 | python-dev | set | messages: + msg230875 |
| 2014-11-05 20:13:33 | serhiy.storchaka | set | assignee: docs@python -> berker.peksag stage: patch review -> commit review |
| 2014-11-04 07:50:21 | georg.brandl | set | messages: + msg230588 |
| 2014-11-02 15:05:39 | serhiy.storchaka | set | messages: + msg230488 |
| 2014-11-02 12:10:15 | berker.peksag | set | files:
+ issue22695_v2.diff messages: + msg230485 |
| 2014-11-01 19:38:35 | serhiy.storchaka | set | status: closed -> open resolution: fixed -> (no value) stage: patch review |
| 2014-11-01 17:54:14 | berker.peksag | set | files:
+ issue22695.diff keywords: + patch messages: + msg230454 |
| 2014-10-27 17:49:12 | Василий.Макаров | set | status: open -> closed resolution: fixed messages: + msg230081 |
| 2014-10-23 23:14:23 | berker.peksag | set | nosy:
+ berker.peksag |
| 2014-10-22 13:34:13 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg229822 |
| 2014-10-22 09:03:04 | vstinner | set | messages: + msg229806 |
| 2014-10-22 09:01:56 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka, georg.brandl messages: + msg229805 versions: - Python 3.2, Python 3.3, Python 3.6 |
| 2014-10-22 07:58:36 | vstinner | set | nosy:
+ vstinner messages: + msg229804 |
| 2014-10-22 07:57:58 | python-dev | set | nosy:
+ python-dev messages: + msg229803 |
| 2014-10-22 07:50:21 | Василий.Макаров | create | |