classification
Title: Idle: update htest.py and htests
Type: behavior Stage: needs patch
Components: IDLE Versions: Python 3.8
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: Saimadhav.Heblikar, python-dev, terry.reedy
Priority: normal Keywords: patch

Created on 2014-10-14 03:33 by terry.reedy, last changed 2019-02-21 00:50 by terry.reedy.

Files
File name Uploaded Description Edit
@htest-34.diff terry.reedy, 2014-10-14 03:33 review
@htest-34-2.diff terry.reedy, 2014-10-17 05:31 review
Messages (5)
msg229278 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2014-10-14 03:33
After using idle-test/htest.py and individual htests when editing files, a few updates are needed.

1. Improve the docstring for htest.py; add info about "# htest #" and #2 below.

2. Use Toplevel(parent) instead of Tk() for test-specific childs windows of the main, master window.  Currently, for some tests, such as CallTipWindow, the focus does not properly shift to the test window. Closing the master window first leaves the test window open.  Closing the test window second then causes several tcl errors (printed to console if available), a Windows message, and an Idle freeze of 5 seconds or more before Idle works again.  The change in this initial patch fixes the focus, non-close, error, and hang problems.  One click and the test window is ready to go; one click on the master and both go away.

3. Coding style issues -- I prefer to use winfo_rootx/y, as done elsewhere in Idle, to using re (close call).  For CallTipWindow, the inner class is not needed now, if it ever was.
msg229565 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2014-10-17 05:31
This patch stop with first like of grep htest.  I am pushing this as a first chunk.
msg229566 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-10-17 05:32
New changeset f5be7fc270d1 by Terry Jan Reedy in branch '2.7':
Issue #22629: Revise idle_test.htest, mostly docstring.  Start revision of
https://hg.python.org/cpython/rev/f5be7fc270d1

New changeset e73f1d813f1f by Terry Jan Reedy in branch '3.4':
Issue #22629: Revise idle_test.htest, mostly docstring.  Start revision of
https://hg.python.org/cpython/rev/e73f1d813f1f

New changeset d8ac11794f26 by Terry Jan Reedy in branch 'default':
Merge with 3.4: Issue #22629
https://hg.python.org/cpython/rev/d8ac11794f26
msg229567 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2014-10-17 05:37
Uh, stops with first line.
msg336168 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2019-02-21 00:50
As far as I can tell, the entire diff in @htest-34-2.diff was pushed.  My comment about 'up to first line of grep' was correct alphabetically but confusing because files with a '# htest #' section were not completely alphabetical in the file.  I need to review current code in light of this issue and a couple of others.
History
Date User Action Args
2019-02-21 00:50:19terry.reedysetmessages: + msg336168
versions: + Python 3.8, - Python 2.7, Python 3.4, Python 3.5
2017-07-04 23:47:53terry.reedylinkissue21624 dependencies
2014-10-17 05:37:51terry.reedysetmessages: + msg229567
2014-10-17 05:32:50python-devsetnosy: + python-dev
messages: + msg229566
2014-10-17 05:31:24terry.reedysetfiles: + @htest-34-2.diff
title: Idle: update htest.py and hests -> Idle: update htest.py and htests
messages: + msg229565

assignee: terry.reedy
stage: patch review -> needs patch
2014-10-14 03:33:50terry.reedycreate