classification
Title: Logging fileConfig behavior does not match documentation
Type: behavior Stage: resolved
Components: Library (Lib) Versions: Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Brendan.Meeder, python-dev, vinay.sajip
Priority: normal Keywords:

Created on 2014-08-03 17:16 by Brendan.Meeder, last changed 2014-08-05 18:01 by vinay.sajip. This issue is now closed.

Messages (4)
msg224648 - (view) Author: Brendan Meeder (Brendan.Meeder) Date: 2014-08-03 17:16
The 2.7.8 documentation for fileConfig says that for disable_existing_loggers:

"If specified as False, loggers which exist when this call is made are left alone."

This is actually not the case- they are enabled after the call to fileConfig. In particular, the loggers that would be disabled if disable_existing_loggers=True are enabled after the call, regardless of whether they were previously enabled/disabled.
msg224815 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-08-05 09:35
New changeset 17e1af9ad66c by Vinay Sajip in branch '2.7':
Issue #22130: Corrected fileConfig() documentation.
http://hg.python.org/cpython/rev/17e1af9ad66c

New changeset 734d5ab0ce6a by Vinay Sajip in branch '3.4':
Issue #22130: Corrected fileConfig() documentation.
http://hg.python.org/cpython/rev/734d5ab0ce6a

New changeset 29665ab293fa by Vinay Sajip in branch 'default':
Closes #22130: Merged documentation update from 3.4.
http://hg.python.org/cpython/rev/29665ab293fa
msg224826 - (view) Author: Brendan Meeder (Brendan.Meeder) Date: 2014-08-05 13:33
Hi there,
  I appreciate the change to documentation but still find the updated wording misleading.  Existing loggers are not "left enabled," implying that existing loggers that were disabled before the call to fileConfig remain disabled after the call to fileConfig.  It is this point in particular that was problematic for our organization.
msg224867 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2014-08-05 18:01
Actually, 'left enabled' means that they are left in an enabled state when the fileConfig() code is finished with them. This is unconnected with whatever state they might have had before the call to fileConfig(). I'm not sure it's worth belabouring the point too much, though.
History
Date User Action Args
2014-08-05 18:01:03vinay.sajipsetmessages: + msg224867
2014-08-05 13:33:32Brendan.Meedersetmessages: + msg224826
2014-08-05 09:35:20python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg224815

resolution: fixed
stage: resolved
2014-08-05 00:28:52berker.peksagsetnosy: + vinay.sajip
2014-08-03 17:16:57Brendan.Meedercreate