➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-07-31 00:42 by zvyn, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| imaplib_test.patch | zvyn, 2014-07-31 00:45 | review | ||
| imaplib_testV2.patch | zvyn, 2014-07-31 14:19 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg224367 - (view) | Author: Milan Oberkirch (zvyn) * | Date: 2014-07-31 00:42 | |
The status quo of test_imaplib is a bit frustrating: 4 test functions out of 31 get executed by default while only few seem to need any resources. I tried to solve this in the attached patch. Did I get something wrong or was that checking for network resources just a mistake? |
|||
| msg224404 - (view) | Author: Milan Oberkirch (zvyn) * | Date: 2014-07-31 14:19 | |
AntoinePitrou: Thanks for the review! I made the suggested changes and could not resist refactoring the hole thing (since I plan to spend some time on that file I wanted it to be readable and pep conform). |
|||
| msg224414 - (view) | Author: Antoine Pitrou (pitrou) *  |
Date: 2014-07-31 15:19 | |
Thank you, Milan. The latest patch looks good to me. |
|||
| msg224448 - (view) | Author: Roundup Robot (python-dev)  |
Date: 2014-07-31 22:35 | |
New changeset 6b2cafab7a9f by Antoine Pitrou in branch 'default': Issue #22111: Assorted cleanups in test_imaplib. Patch by Milan Oberkirch. http://hg.python.org/cpython/rev/6b2cafab7a9f |
|||
| msg224449 - (view) | Author: Antoine Pitrou (pitrou) * |
Date: 2014-07-31 22:38 | |
This is now pushed. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:06 | admin | set | github: 66309 |
| 2014-07-31 22:38:18 | pitrou | set | status: open -> closed resolution: fixed messages: + msg224449 stage: resolved |
| 2014-07-31 22:35:53 | python-dev | set | nosy:
+ python-dev messages: + msg224448 |
| 2014-07-31 15:19:27 | pitrou | set | messages: + msg224414 |
| 2014-07-31 14:19:56 | zvyn | set | files:
+ imaplib_testV2.patch messages: + msg224404 |
| 2014-07-31 00:45:42 | zvyn | set | files: + imaplib_test.patch |
| 2014-07-31 00:44:06 | zvyn | set | files: - imaplib_test.patch |
| 2014-07-31 00:42:38 | zvyn | create | |