classification
Title: hashtable.c not using PY_FORMAT_SIZE_T
Type: Stage: resolved
Components: Versions: Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: John.Malmberg, python-dev, vstinner
Priority: normal Keywords:

Created on 2014-07-01 04:59 by John.Malmberg, last changed 2014-07-04 20:50 by python-dev. This issue is now closed.

Files
File name Uploaded Description Edit
hashtable.gdiff John.Malmberg, 2014-07-01 04:59 Patch to use PY_FORMAT_SIZE_T
Messages (4)
msg222008 - (view) Author: John Malmberg (John.Malmberg) * Date: 2014-07-01 04:59
hashtable.c is using %zd instead of the PY_FORMAT_SIZE_T as set by configure.

Comments in pymacconfig.h state that this will cause problems on OS-X 10.4 with binaries build on OS-X 10.5.

The attached patch hashtable.giff changes hashtable.c to be like the other modules that use PY_FORMAT_SIZE_T.
msg222017 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-07-01 06:58
New changeset 4f55e802baf0 by Victor Stinner in branch '3.4':
Closes #21892, #21893: Use PY_FORMAT_SIZE_T instead of %zi or %zu to format C
http://hg.python.org/cpython/rev/4f55e802baf0

New changeset 669b43bffd87 by Victor Stinner in branch 'default':
(Merge 3.4) Closes #21892, #21893: Use PY_FORMAT_SIZE_T instead of %zi or %zu
http://hg.python.org/cpython/rev/669b43bffd87
msg222018 - (view) Author: STINNER Victor (vstinner) * (Python committer) Date: 2014-07-01 06:58
Oh, I forgot the mention John Malmberg in the changelog, sorry :-(

Thanks for your fix John.
msg222314 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-07-04 20:50
New changeset 6fb1e2ce513a by Victor Stinner in branch '3.4':
Issue #21892, #21893: Partial revert of changeset 4f55e802baf0, PyErr_Format()
http://hg.python.org/cpython/rev/6fb1e2ce513a

New changeset 58cd562e3ef9 by Victor Stinner in branch 'default':
(Merge 3.4) Issue #21892, #21893: Partial revert of changeset 4f55e802baf0,
http://hg.python.org/cpython/rev/58cd562e3ef9
History
Date User Action Args
2014-07-04 20:50:42python-devsetmessages: + msg222314
2014-07-01 09:43:53berker.peksagsetstage: resolved
2014-07-01 06:58:44vstinnersetmessages: + msg222018
stage: resolved -> (no value)
2014-07-01 06:58:06python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg222017

resolution: fixed
stage: resolved
2014-07-01 06:35:34ned.deilysetnosy: + vstinner
2014-07-01 04:59:13John.Malmbergcreate