classification
Title: Devguide: mention requirement to install Visual Studio SP1 on Windows
Type: enhancement Stage: resolved
Components: Devguide Versions:
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: benhoyt, docs@python, ezio.melotti, python-dev, r.david.murray, steve.dower, zach.ware
Priority: normal Keywords: patch

Created on 2014-06-13 04:19 by benhoyt, last changed 2014-06-13 15:09 by zach.ware. This issue is now closed.

Files
File name Uploaded Description Edit
visual_studio_sp1.patch benhoyt, 2014-06-13 04:19
Messages (6)
msg220418 - (view) Author: Ben Hoyt (benhoyt) * Date: 2014-06-13 04:19
Per my email on core-mentorship, the instructions for compiling CPython on Windows at
https://docs.python.org/devguide/setup.html#windows are good, however I did have one issue where the dev guide didn't help. During the link
step, I got this error:

LINK : fatal error LNK1123: failure during conversion to COFF: file
invalid or corrupt

It took me a while to figure out how to fix it. I found this question
on StackOverflow:

http://stackoverflow.com/questions/10888391/error-link-fatal-error-lnk1123-failure-during-conversion-to-coff-file-inval

The first part of the answer didn't help (because incremental linking
is already disabled). But the second part, kinda tucked away there, is
what fixed it for me -- simply installing Visual Studio 2010 SP1 here:

http://www.microsoft.com/en-us/download/details.aspx?id=23691

After this, I restarted my PC and it linked fine.

So I suggest a small addition to the dev guide to mention this -- adding the following paragraph after the "Python 3.3 and later" paragraph:

-----
You'll also need to install the Visual Studio `Service Pack 1 (SP1)
<http://www.microsoft.com/en-us/download/details.aspx?id=23691>`_. If you
don't install this service pack, you may receive errors like the following
during linking: ``LINK : fatal error LNK1123: failure during conversion to
COFF: file invalid or corrupt``.
-----

Patch attached.
msg220446 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-06-13 14:39
New changeset 9794412fa62d by Zachary Ware in branch 'default':
Issue #21745: Mention VS2010 SP1 as a solution for error LNK1123.
http://hg.python.org/devguide/rev/9794412fa62d
msg220447 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-06-13 14:39
New changeset 10cca530d14c by Zachary Ware in branch '3.4':
Issue #21745: Mention VS2010 SP1 as a solution for LNK1123 errors
http://hg.python.org/cpython/rev/10cca530d14c

New changeset b5b54073d495 by Zachary Ware in branch 'default':
Issue #21745: Merge with 3.4
http://hg.python.org/cpython/rev/b5b54073d495
msg220448 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-06-13 14:44
Fixed, thanks for the patch!
msg220451 - (view) Author: Ben Hoyt (benhoyt) * Date: 2014-06-13 15:03
Cool, thanks for applying. Out of curiosity, how often is the online devguide HTML updated?
msg220452 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-06-13 15:09
I'm not sure; I expect your change to be live within a day, probably sooner.
History
Date User Action Args
2014-06-13 15:09:25zach.waresetmessages: + msg220452
2014-06-13 15:03:39benhoytsetmessages: + msg220451
2014-06-13 14:44:25zach.waresetstatus: open -> closed
messages: + msg220448

assignee: docs@python -> zach.ware
resolution: fixed
stage: resolved
2014-06-13 14:39:57python-devsetmessages: + msg220447
2014-06-13 14:39:48python-devsetnosy: + python-dev
messages: + msg220446
2014-06-13 04:32:09berker.peksagsetnosy: + ezio.melotti, zach.ware, steve.dower
components: + Devguide, - Documentation
2014-06-13 04:20:01benhoytsetnosy: + r.david.murray
2014-06-13 04:19:25benhoytcreate