This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: Improved error msg for make.bat htmlhelp
Type: enhancement Stage: resolved
Components: Windows Versions: Python 3.4, Python 3.5
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: zach.ware Nosy List: Olive.Kilburn, python-dev, zach.ware
Priority: normal Keywords: patch

Created on 2014-06-07 19:15 by Olive.Kilburn, last changed 2022-04-11 14:58 by admin. This issue is now closed.

File name Uploaded Description Edit
mywork.patch Olive.Kilburn, 2014-06-07 22:26 review
mywork.patch Olive.Kilburn, 2014-06-09 21:37 review
Messages (6)
msg219961 - (view) Author: Olive Kilburn (Olive.Kilburn) * Date: 2014-06-07 19:15
Currently if someone runs make.bat htmlhelp without first installing Htmlhelp Workshop, it outputs: 
c:\program not a valid . . . .

This isn't very informative if you don't know you need Htmlhelp Workshop. The included patch has make.bat give a more helpful message. If this isn't a good fix(?), I could try clarifying the readme instead.
msg220106 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-06-09 18:16
Could you give me the exact message you get currently?  If it's just "'C:\Program' is not recognized as an internal or external command, operable program or batch file.", that's a different issue than if the whole path to hhc.exe is displayed.

Otherwise, I like the patch, except you can reuse the %HTMLHELP% variable instead of reconstructing it from %_PRGMFLS%.
msg220121 - (view) Author: Olive Kilburn (Olive.Kilburn) * Date: 2014-06-09 21:37
Before I installed HTML Help Workshop it would output many lines followed by
build succeeded, 1 warning. 
C:\Program is not recognized as an internal or external command, operable program or batch file. 

Build succeeded. All output should be in build\htmlhelp

build\htmlhelp would not be created however.

Thank you for pointing out the variable, I've fixed it.
msg220177 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-06-10 17:08
New changeset b841b80e6421 by Zachary Ware in branch '3.4':
Issue #21688: Give informative error message when hhc.exe cannot be found.

New changeset e5594e751a2e by Zachary Ware in branch 'default':
Issue #21688: Merge with 3.4
msg220178 - (view) Author: Zachary Ware (zach.ware) * (Python committer) Date: 2014-06-10 17:10
Fixed!  I tweaked the message a bit and added errorlevel setting before committing.

Thanks for the report and patch!
msg220318 - (view) Author: Olive Kilburn (Olive.Kilburn) * Date: 2014-06-11 22:38
Date User Action Args
2022-04-11 14:58:04adminsetgithub: 65887
2014-06-11 22:38:37Olive.Kilburnsetmessages: + msg220318
2014-06-10 17:10:16zach.waresetstatus: open -> closed
versions: + Python 3.4
messages: + msg220178

assignee: zach.ware
resolution: fixed
stage: resolved
2014-06-10 17:08:36python-devsetnosy: + python-dev
messages: + msg220177
2014-06-09 21:37:17Olive.Kilburnsetfiles: + mywork.patch

messages: + msg220121
2014-06-09 18:16:16zach.waresetmessages: + msg220106
2014-06-08 23:03:22r.david.murraysetnosy: + zach.ware
2014-06-07 22:26:46Olive.Kilburnsetfiles: - mywork.patch
2014-06-07 22:26:00Olive.Kilburnsetfiles: + mywork.patch
2014-06-07 19:15:03Olive.Kilburncreate