➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014-06-02 14:55 by Claudiu.Popa, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| smtplib_resource_warning.patch | Claudiu.Popa, 2014-06-02 14:55 | review | ||
| issue21641.patch | Claudiu.Popa, 2014-06-03 08:23 | review | ||
| Messages (5) | |||
|---|---|---|---|
| msg219592 - (view) | Author: PCManticore (Claudiu.Popa) *  |
Date: 2014-06-02 14:55 | |
Hello!
I noticed that test_smtplib raises a ResourceWarning, tracking this to this piece of code:
self.assertRaises(smtplib.SMTPResponseException, smtplib.SMTP,
HOST, self.port, 'localhost', 3)
What happens is that `SMTP.getreply` is called in `SMTP.__init__` after the socket was opened, but if getreply raises SMTPResponseException, the socket remains opened. The attached patch fixes this.
|
|||
| msg219593 - (view) | Author: PCManticore (Claudiu.Popa) * |
Date: 2014-06-02 14:57 | |
An alternative to this approach would be to catch the error in __init__ and close the socket there. |
|||
| msg219669 - (view) | Author: PCManticore (Claudiu.Popa) * |
Date: 2014-06-03 08:23 | |
It's actually better to close the socket in __init__ in this case. |
|||
| msg219690 - (view) | Author: Roundup Robot (python-dev) |
Date: 2014-06-03 14:25 | |
New changeset d5c76646168d by Senthil Kumaran in branch '3.4': Fix issue #21641: Close the socket before raising the SMTPResponseException. Fixes the ResourceWarning in the test run. http://hg.python.org/cpython/rev/d5c76646168d New changeset 7ea84a25d863 by Senthil Kumaran in branch 'default': merge from 3.4 http://hg.python.org/cpython/rev/7ea84a25d863 |
|||
| msg219691 - (view) | Author: Senthil Kumaran (orsenthil) *  |
Date: 2014-06-03 14:26 | |
The first patch was correct and consistent with how other Exceptions were closing the socket. Fixed this and thanks for the patch. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:04 | admin | set | github: 65840 |
| 2014-06-03 14:26:53 | orsenthil | set | status: open -> closed assignee: orsenthil versions: + Python 3.4 nosy: + orsenthil messages: + msg219691 resolution: fixed stage: resolved |
| 2014-06-03 14:25:48 | python-dev | set | nosy:
+ python-dev messages: + msg219690 |
| 2014-06-03 08:23:48 | Claudiu.Popa | set | files:
+ issue21641.patch messages: + msg219669 |
| 2014-06-02 14:57:54 | Claudiu.Popa | set | messages: + msg219593 |
| 2014-06-02 14:55:42 | Claudiu.Popa | create | |