This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: setup.py: More informative error msg for modules which built but failed import check
Type: enhancement Stage: resolved
Components: Build Versions: Python 3.4, Python 3.5, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: Nosy List: Arfrever, Lukas.Vacek, python-dev
Priority: normal Keywords:

Created on 2014-04-17 11:09 by Lukas.Vacek, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
setup_failed_import_hgexport Lukas.Vacek, 2014-04-17 11:09 review
Messages (2)
msg216684 - (view) Author: Lukas Vacek (Lukas.Vacek) * Date: 2014-04-17 11:09
Hey,

Currently when a module builds successfully during cpython build but it can't be imported (import check around line 330 in setup.py) the module shows in "Failed to build these modules: " which can be misleading.

Especially when linking against libraries in non-standard locations the user would set LD_FLAGS and CPPFLAGS and then ... wonder why the cpython build process is not picking the libraries up and the module is not built.

I think the modules which *have built* but were removed because of a failed import check should be marked as such so the user knows what happens and can take appropriate actions (set LD_LIBRARY_PATH as well, for example).

A patch attached - it's a very simple change (about 10 lines), created with "hg export".

Thanks,
Lucas
msg217621 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-04-30 15:06
New changeset 981242c8fc86 by Benjamin Peterson in branch 'default':
setup.py: report modules which built but import failed (closes #21282)
http://hg.python.org/cpython/rev/981242c8fc86
History
Date User Action Args
2022-04-11 14:58:02adminsetgithub: 65481
2014-04-30 15:06:39python-devsetstatus: open -> closed

nosy: + python-dev
messages: + msg217621

resolution: fixed
stage: resolved
2014-04-17 21:36:11Arfreversetnosy: + Arfrever

versions: - Python 3.1, Python 3.2, Python 3.3
2014-04-17 11:09:22Lukas.Vacekcreate