classification
Title: Roundtrip-test tokenize.untokenize(iterable_of_5_tuples)
Type: behavior Stage: needs patch
Components: Library (Lib), Tests Versions: Python 3.3, Python 3.4
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: terry.reedy Nosy List: python-dev, terry.reedy
Priority: normal Keywords:

Created on 2014-02-23 22:07 by terry.reedy, last changed 2014-02-23 23:06 by terry.reedy.

Messages (3)
msg212034 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2014-02-23 22:07
Currently, test_tokenize.roundtrip only tests the 2-tuple mode of untokenize. The currently buggy 5-tuple mode needs to be tested also, as far as possible, to reduce the chance of introducing more bugs when fixing current bugs. When this is done, all the constructed tests pass. Good so far.

The doctest normally tests 10 files selected from test/test_*.py and a few tries showed no problem. However, when testing all with -ucpu. 
F:\Python\dev> 3\py33\pcbuild\python_d -m test -ucpu test_tokenize
7 failed. So we must remove these from the list of candidates until the failure cause is determined and either fixed or determined not fixable (as with test_3131.py).

As suggested in the revised docstring, finding the failure items for these 7 would be much easier if the file roundtrip test were removed from the doctest and made into a unittest with assertEqual.
msg212040 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-02-23 23:01
New changeset 8d6dd02a973f by Terry Jan Reedy in branch '3.3':
Issue #20750, Enable roundtrip tests for new 5-tuple untokenize. The
http://hg.python.org/cpython/rev/8d6dd02a973f

New changeset 73aa6d672b81 by Terry Jan Reedy in branch 'default':
Merge with 3.3, #20750
http://hg.python.org/cpython/rev/73aa6d672b81
msg212043 - (view) Author: Terry J. Reedy (terry.reedy) * (Python committer) Date: 2014-02-23 23:06
The 2.7 tokenize tests do not have roundtrip tests.
 
Excluding the 7 files is a temporary hack. The issue should stay open until each either passes and is removed from the exclusion list or is determined to be a permanent exclusion, like test_pep3131.
History
Date User Action Args
2014-02-23 23:06:29terry.reedysetmessages: + msg212043
2014-02-23 23:01:27python-devsetnosy: + python-dev
messages: + msg212040
2014-02-23 22:07:06terry.reedycreate