classification
Title: test_socket: testSendmsgDontWait needlessly skipped on Linux
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: serhiy.storchaka Nosy List: baikie, python-dev, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2014-02-22 22:16 by baikie, last changed 2014-11-19 11:27 by serhiy.storchaka. This issue is now closed.

Files
File name Uploaded Description Edit
test_socket-platform.diff baikie, 2014-02-22 22:16 Check for sys.platform == "linux" rather than "linux2"
Messages (4)
msg211965 - (view) Author: David Watson (baikie) Date: 2014-02-22 22:16
In test_socket, the decorator on SendmsgStreamTests.testSendmsgDontWait still checks for the old sys.platform value of "linux2", with the result that the test is always skipped, when in fact the test is for a Linux facility.  Patch attached for 3.3 and above.
msg231369 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-19 11:21
LGTM.
msg231370 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-11-19 11:24
New changeset fb06c8ccfd41 by Serhiy Storchaka in branch '3.4':
Issue #20736: testSendmsgDontWait in test_socket no longer skipped on Linux.
https://hg.python.org/cpython/rev/fb06c8ccfd41

New changeset 23ab1197df0b by Serhiy Storchaka in branch 'default':
Issue #20736: testSendmsgDontWait in test_socket no longer skipped on Linux.
https://hg.python.org/cpython/rev/23ab1197df0b
msg231371 - (view) Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) Date: 2014-11-19 11:27
Thank you for your report and patch David.
History
Date User Action Args
2014-11-19 11:27:22serhiy.storchakasetstatus: open -> closed
resolution: fixed
messages: + msg231371

stage: commit review -> resolved
2014-11-19 11:24:21python-devsetnosy: + python-dev
messages: + msg231370
2014-11-19 11:21:14serhiy.storchakasetversions: - Python 3.3
nosy: + serhiy.storchaka

messages: + msg231369

assignee: serhiy.storchaka
stage: commit review
2014-02-22 22:16:08baikiecreate