classification
Title: 3.4 cherry-pick: d6aa3fa646e2 inspect.signature: Check for function-like objects before builtins
Type: Stage:
Components: Versions: Python 3.4
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: larry Nosy List: larry, scoder, yselivanov
Priority: release blocker Keywords:

Created on 2014-02-21 23:36 by yselivanov, last changed 2014-02-22 16:29 by yselivanov. This issue is now closed.

Messages (4)
msg211894 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2014-02-21 23:36
Another tweak in signature. Fixes #17159 once and for all (and will save Stefan from adding ugly hacks in Cython).

I'm not sure if it is a release blocker or can wait till 3.4.1; all I can say is that the change is relatively simple, as it shouldn't matter what we try first - from_function() or from_builtin(). It's your call.

changeset:   89320:d6aa3fa646e2
tag:         tip
user:        Yury Selivanov <yselivanov@sprymix.com>
date:        Fri Feb 21 18:30:53 2014 -0500
files:       Lib/inspect.py Lib/test/test_inspect.py
description:
inspect.signature: Check for function-like objects before builtins. Issue #17159
msg211911 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-02-22 07:33
I'm waiting to hear back from scoder about whether or not this really fixes his problem before I cherry-pick.  I'm still willing to do it for tagging for rc2 (about 20 hours from now) if I can hear back during that time.
msg211913 - (view) Author: Larry Hastings (larry) * (Python committer) Date: 2014-02-22 07:44
I reconsidered, and the sense I get is "yeah it fixes the problem".  And even if it didn't, I'd wind up cherry-picking it anyway just to make the diffs easier.  So I'm accepting this.
msg211929 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2014-02-22 16:29
Thanks, Larry!
History
Date User Action Args
2014-02-22 16:29:52yselivanovsetmessages: + msg211929
2014-02-22 07:44:40larrysetstatus: open -> closed
resolution: fixed
messages: + msg211913
2014-02-22 07:33:14larrysetnosy: + scoder
messages: + msg211911
2014-02-21 23:36:52yselivanovcreate